You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by "hailin0 (via GitHub)" <gi...@apache.org> on 2023/04/10 12:01:09 UTC

[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #4524: [Improve][connector][kafka] Set default value for partition option

hailin0 commented on code in PR #4524:
URL: https://github.com/apache/incubator-seatunnel/pull/4524#discussion_r1161663205


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkFactory.java:
##########
@@ -50,7 +50,6 @@ public OptionRule optionRule() {
                         Config.ASSIGN_PARTITIONS,
                         Config.TRANSACTION_PREFIX,
                         Config.SEMANTICS)
-                .exclusive(Config.PARTITION, Config.PARTITION_KEY_FIELDS)

Review Comment:
   why delete?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org