[GitHub] [hive] steveloughran commented on a change in pull request #1893: HIVE-24669: Improve FileSystem usage in Hive::loadPartitionInternal

[GitBox <gi...@apache.org>]

steveloughran commented on a change in pull request #1893:
URL: https://github.com/apache/hive/pull/1893#discussion_r562749017



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java
##########
@@ -117,6 +117,10 @@ public static long createTestFileId(
     }
     return result;
   }
+  public static List<Path> listPath(final FileSystem fs, final Path path, final PathFilter filter,

Review comment:
       1. if you could process the results with any computation per record, you will get full benefits of the async page fetch offered by s3a and (soon) abfs; at 600ms a list for 200 records on s3, that's potentially 3ms/record saving
   2. If `listLocatedFileStatus()` logged @ debug the toString() value of the iterator, the S3A FS iterator will print out its IOStats, including #of S3 list requests and  min/mean/max durations. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org