You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jason van Zyl <ja...@maven.org> on 2007/01/07 03:59:17 UTC
Re: svn commit: r493534 - in /maven/plugins/trunk/maven-repository-plugin/src: main/java/org/apache/maven/plugins/repository/BundleCreateMojo.java test/java/org/apache/maven/plugins/repository/BundleCreateMojoTest.java
On 6 Jan 07, at 1:45 PM 6 Jan 07, fgiust@apache.org wrote:
> Author: fgiust
> Date: Sat Jan 6 10:45:46 2007
> New Revision: 493534
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=493534
> Log:
> MREPOSITORY-2 project.scm.connection should not be required for
> bundle-create
>
Why not?
> Modified:
> maven/plugins/trunk/maven-repository-plugin/src/main/java/org/
> apache/maven/plugins/repository/BundleCreateMojo.java
> maven/plugins/trunk/maven-repository-plugin/src/test/java/org/
> apache/maven/plugins/repository/BundleCreateMojoTest.java
>
> Modified: maven/plugins/trunk/maven-repository-plugin/src/main/java/
> org/apache/maven/plugins/repository/BundleCreateMojo.java
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-
> repository-plugin/src/main/java/org/apache/maven/plugins/repository/
> BundleCreateMojo.java?view=diff&rev=493534&r1=493533&r2=493534
> ======================================================================
> ========
> --- maven/plugins/trunk/maven-repository-plugin/src/main/java/org/
> apache/maven/plugins/repository/BundleCreateMojo.java (original)
> +++ maven/plugins/trunk/maven-repository-plugin/src/main/java/org/
> apache/maven/plugins/repository/BundleCreateMojo.java Sat Jan 6
> 10:45:46 2007
> @@ -80,7 +80,6 @@
> // name
> // version
> // url
> - // scm url
> // description
> // dependencies
> // licenses
> @@ -89,13 +88,6 @@
> validate( project.getName(), "project.name" );
>
> validate( project.getUrl(), "project.url" );
> -
> - if ( project.getScm() == null )
> - {
> - throw new MojoExecutionException( "Project scm element
> is null." );
> - }
> -
> - validate( project.getScm().getConnection(),
> "project.scm.connection" );
>
> validate( project.getDescription(), "project.description" );
>
>
> Modified: maven/plugins/trunk/maven-repository-plugin/src/test/java/
> org/apache/maven/plugins/repository/BundleCreateMojoTest.java
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-
> repository-plugin/src/test/java/org/apache/maven/plugins/repository/
> BundleCreateMojoTest.java?view=diff&rev=493534&r1=493533&r2=493534
> ======================================================================
> ========
> --- maven/plugins/trunk/maven-repository-plugin/src/test/java/org/
> apache/maven/plugins/repository/BundleCreateMojoTest.java (original)
> +++ maven/plugins/trunk/maven-repository-plugin/src/test/java/org/
> apache/maven/plugins/repository/BundleCreateMojoTest.java Sat Jan
> 6 10:45:46 2007
> @@ -324,16 +324,11 @@
>
> File testPom = new File( getBasedir(), "src/test/resources/
> unit/no-scm/pom.xml" );
>
> - try
> - {
> - BundleCreateMojo mojo = (BundleCreateMojo) lookupMojo
> ( "bundle-create", testPom );
> - mojo.execute();
> - fail( "Must throw an exception on a project element
> scm is null" );
> - }
> - catch ( Exception e )
> - {
> - assertTrue( true );
> - }
> + BundleCreateMojo mojo = (BundleCreateMojo) lookupMojo
> ( "bundle-create", testPom );
> + mojo.execute();
> +
> + // MREPOSITORY-2 project.scm.connection should not be
> required for bundle-create
> + // fail( "Must throw an exception on a project element scm
> is null" );
>
> }
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r493534 - in /maven/plugins/trunk/maven-repository-plugin/src:
main/java/org/apache/maven/plugins/repository/BundleCreateMojo.java test/java/org/apache/maven/plugins/repository/BundleCreateMojoTest.java
Posted by Trygve Laugstøl <tr...@apache.org>.
Jason van Zyl wrote:
>
> On 8 Jan 07, at 3:26 AM 8 Jan 07, Trygve Laugstøl wrote:
>
>> Jason van Zyl wrote:
>>> On 7 Jan 07, at 12:30 PM 7 Jan 07, Fabrizio Giustina wrote:
>>>> On 1/7/07, Jason van Zyl <ja...@maven.org> wrote:
>>>>>
>>>>> On 6 Jan 07, at 1:45 PM 6 Jan 07, fgiust@apache.org wrote:
>>>>> > MREPOSITORY-2 project.scm.connection should not be required for
>>>>> > bundle-create
>>>>> >
>>>>>
>>>>> Why not?
>>>>
>>>> the project could not have a public repository, there are projects
>>>> that only distribute binary/source jars without having an accessible
>>>> scm at all.
>>> Can you give me an example of an OSS project submitting something to
>>> the central repository that doesn't have a public repository? How can
>>> you operate as an OSS project without a public repository?
>>
>> There are already several examples on that there. There is nothing in
>> the OSS licenses that requires the source to be publicly available all
>> the time, only the parts that you distribute.
>>
>
> No, there is nothing required other then a stipulation we would make.
> Some traceability for artifacts placed in the repository. My thinking is
> that at some point in the very near future submissions would be made in
> the form of giving us a POM we can use to build the code and push into
> the repository.
That would be really cool. and a very useful feature for a lot of
projects in the way that we could make sure that their POMs are good and
that their released project's builds are actually re-producable.
--
Trygve
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r493534 - in /maven/plugins/trunk/maven-repository-plugin/src: main/java/org/apache/maven/plugins/repository/BundleCreateMojo.java test/java/org/apache/maven/plugins/repository/BundleCreateMojoTest.java
Posted by Jason van Zyl <ja...@maven.org>.
On 8 Jan 07, at 3:26 AM 8 Jan 07, Trygve Laugstøl wrote:
> Jason van Zyl wrote:
>> On 7 Jan 07, at 12:30 PM 7 Jan 07, Fabrizio Giustina wrote:
>>> On 1/7/07, Jason van Zyl <ja...@maven.org> wrote:
>>>>
>>>> On 6 Jan 07, at 1:45 PM 6 Jan 07, fgiust@apache.org wrote:
>>>> > MREPOSITORY-2 project.scm.connection should not be required for
>>>> > bundle-create
>>>> >
>>>>
>>>> Why not?
>>>
>>> the project could not have a public repository, there are projects
>>> that only distribute binary/source jars without having an accessible
>>> scm at all.
>> Can you give me an example of an OSS project submitting something
>> to the central repository that doesn't have a public repository?
>> How can you operate as an OSS project without a public repository?
>
> There are already several examples on that there. There is nothing
> in the OSS licenses that requires the source to be publicly
> available all the time, only the parts that you distribute.
>
No, there is nothing required other then a stipulation we would make.
Some traceability for artifacts placed in the repository. My thinking
is that at some point in the very near future submissions would be
made in the form of giving us a POM we can use to build the code and
push into the repository.
>>> It doesn't make sense that repository:bundle-create require it to
>>> work, also because it's not really useful for users
>> It's definitely useful for users to have the location of the
>> source repository. Especially from IDEs if you grab a remote POM
>> and want to create a project.
>>> (on the other hand
>>> license info was not mandatory, and that's something that can always
>>> be filled and that is definitively useful).
>> The license file was, but the element being specified is better.
>> Some form of license information was mandatory.
>> I'm -1 to letting people submit without that information. Your
>> justification is unsatisfactory as is.
>
> How about just having a big, fat warning about the POM not having
> SCM information? Then it's up t the uploader to take action if it
> *should* have SCM (like all apache, codehaus and sourceforge
> projects should have).
>
> --
> Trygve
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r493534 - in /maven/plugins/trunk/maven-repository-plugin/src:
main/java/org/apache/maven/plugins/repository/BundleCreateMojo.java test/java/org/apache/maven/plugins/repository/BundleCreateMojoTest.java
Posted by Trygve Laugstøl <tr...@apache.org>.
Jason van Zyl wrote:
>
> On 7 Jan 07, at 12:30 PM 7 Jan 07, Fabrizio Giustina wrote:
>
>> On 1/7/07, Jason van Zyl <ja...@maven.org> wrote:
>>>
>>> On 6 Jan 07, at 1:45 PM 6 Jan 07, fgiust@apache.org wrote:
>>> > MREPOSITORY-2 project.scm.connection should not be required for
>>> > bundle-create
>>> >
>>>
>>> Why not?
>>
>> the project could not have a public repository, there are projects
>> that only distribute binary/source jars without having an accessible
>> scm at all.
>
> Can you give me an example of an OSS project submitting something to the
> central repository that doesn't have a public repository? How can you
> operate as an OSS project without a public repository?
There are already several examples on that there. There is nothing in
the OSS licenses that requires the source to be publicly available all
the time, only the parts that you distribute.
>> It doesn't make sense that repository:bundle-create require it to
>> work, also because it's not really useful for users
>
> It's definitely useful for users to have the location of the source
> repository. Especially from IDEs if you grab a remote POM and want to
> create a project.
>
>> (on the other hand
>> license info was not mandatory, and that's something that can always
>> be filled and that is definitively useful).
>
> The license file was, but the element being specified is better. Some
> form of license information was mandatory.
>
> I'm -1 to letting people submit without that information. Your
> justification is unsatisfactory as is.
How about just having a big, fat warning about the POM not having SCM
information? Then it's up t the uploader to take action if it *should*
have SCM (like all apache, codehaus and sourceforge projects should have).
--
Trygve
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r493534 - in /maven/plugins/trunk/maven-repository-plugin/src:
main/java/org/apache/maven/plugins/repository/BundleCreateMojo.java test/java/org/apache/maven/plugins/repository/BundleCreateMojoTest.java
Posted by Dennis Lundberg <de...@apache.org>.
Jason van Zyl wrote:
>
> On 7 Jan 07, at 12:30 PM 7 Jan 07, Fabrizio Giustina wrote:
>
>> On 1/7/07, Jason van Zyl <ja...@maven.org> wrote:
>>>
>>> On 6 Jan 07, at 1:45 PM 6 Jan 07, fgiust@apache.org wrote:
>>> > MREPOSITORY-2 project.scm.connection should not be required for
>>> > bundle-create
>>> >
>>>
>>> Why not?
>>
>> the project could not have a public repository, there are projects
>> that only distribute binary/source jars without having an accessible
>> scm at all.
>
> Can you give me an example of an OSS project submitting something to the
> central repository that doesn't have a public repository? How can you
> operate as an OSS project without a public repository?
Here's a concrete example an artifact that is available in the
repository. It is closed source in the sense that there is no public SCM
available, but license-wise it's OK to redistribute it:
http://repo1.maven.org/maven2/com/intellij/openapi/5.0/
>> It doesn't make sense that repository:bundle-create require it to
>> work, also because it's not really useful for users
>
> It's definitely useful for users to have the location of the source
> repository. Especially from IDEs if you grab a remote POM and want to
> create a project.
>
>> (on the other hand
>> license info was not mandatory, and that's something that can always
>> be filled and that is definitively useful).
>
> The license file was, but the element being specified is better. Some
> form of license information was mandatory.
>
> I'm -1 to letting people submit without that information. Your
> justification is unsatisfactory as is.
>
> Jason.
>
>>
>> fabrizio
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r493534 - in /maven/plugins/trunk/maven-repository-plugin/src: main/java/org/apache/maven/plugins/repository/BundleCreateMojo.java test/java/org/apache/maven/plugins/repository/BundleCreateMojoTest.java
Posted by Fabrizio Giustina <fg...@apache.org>.
On 1/7/07, Jason van Zyl <ja...@maven.org> wrote:
> Can you give me an example of an OSS project submitting something to
> the central repository that doesn't have a public repository? How can
> you operate as an OSS project without a public repository?
well, these are a couple of small projects I created upload bundles
for in the past that don't have a repository at all:
http://www.lamatek.com/GoogleMaps/
http://schmidt.devlib.org/image-info/
... and other projects may have a repository accessible only from an
intranet (what sense does it make forcing users to put an intranet
server in there?). This limitation was already reported in jira
http://jira.codehaus.org/browse/MREPOSITORY-2
> > It doesn't make sense that repository:bundle-create require it to
> > work, also because it's not really useful for users
>
> It's definitely useful for users to have the location of the source
> repository. Especially from IDEs if you grab a remote POM and want to
> create a project.
right, I agree with that. But we are simply saying that a scm url is
not mandatory, not that we don't want it at all.. I think that all the
elements that really impact most users like the basic project info
(name, ids, description) license and dependencies (that we can't check
automatically) should be made mandatory, but enforcing the
availability of an scm url is probably too much.
>
> > (on the other hand
> > license info was not mandatory, and that's something that can always
> > be filled and that is definitively useful).
>
> The license file was, but the element being specified is better. Some
> form of license information was mandatory.
yes, we are forcing users to add a license file but actually such file
is simply discarded when uploading to a maven 2 repo :(
fabrizio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r493534 - in /maven/plugins/trunk/maven-repository-plugin/src: main/java/org/apache/maven/plugins/repository/BundleCreateMojo.java test/java/org/apache/maven/plugins/repository/BundleCreateMojoTest.java
Posted by Wendy Smoak <ws...@gmail.com>.
On 1/7/07, Jason van Zyl <ja...@maven.org> wrote:
> Can you give me an example of an OSS project submitting something to
> the central repository that doesn't have a public repository? How can
> you operate as an OSS project without a public repository?
Is everything in the central repository OSS? Are there any libraries
that are free to distribute, but for which the source is not
available?
I'm trying to remember why I opened the issue originally. I think it
had to do with an IBM database API that I was going to see if they'd
allow to be placed in the repo. It's not open source, but it's free
in the sense that they distribute it with the personal edition of the
dbms.
It's no longer on my priority list, so reverting and closing the issue
as Won't Fix is fine with me, if no one else wants this.
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r493534 - in /maven/plugins/trunk/maven-repository-plugin/src: main/java/org/apache/maven/plugins/repository/BundleCreateMojo.java test/java/org/apache/maven/plugins/repository/BundleCreateMojoTest.java
Posted by Jason van Zyl <ja...@maven.org>.
On 7 Jan 07, at 12:30 PM 7 Jan 07, Fabrizio Giustina wrote:
> On 1/7/07, Jason van Zyl <ja...@maven.org> wrote:
>>
>> On 6 Jan 07, at 1:45 PM 6 Jan 07, fgiust@apache.org wrote:
>> > MREPOSITORY-2 project.scm.connection should not be required for
>> > bundle-create
>> >
>>
>> Why not?
>
> the project could not have a public repository, there are projects
> that only distribute binary/source jars without having an accessible
> scm at all.
Can you give me an example of an OSS project submitting something to
the central repository that doesn't have a public repository? How can
you operate as an OSS project without a public repository?
> It doesn't make sense that repository:bundle-create require it to
> work, also because it's not really useful for users
It's definitely useful for users to have the location of the source
repository. Especially from IDEs if you grab a remote POM and want to
create a project.
> (on the other hand
> license info was not mandatory, and that's something that can always
> be filled and that is definitively useful).
The license file was, but the element being specified is better. Some
form of license information was mandatory.
I'm -1 to letting people submit without that information. Your
justification is unsatisfactory as is.
Jason.
>
> fabrizio
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r493534 - in /maven/plugins/trunk/maven-repository-plugin/src: main/java/org/apache/maven/plugins/repository/BundleCreateMojo.java test/java/org/apache/maven/plugins/repository/BundleCreateMojoTest.java
Posted by Fabrizio Giustina <fg...@apache.org>.
On 1/7/07, Jason van Zyl <ja...@maven.org> wrote:
>
> On 6 Jan 07, at 1:45 PM 6 Jan 07, fgiust@apache.org wrote:
> > MREPOSITORY-2 project.scm.connection should not be required for
> > bundle-create
> >
>
> Why not?
the project could not have a public repository, there are projects
that only distribute binary/source jars without having an accessible
scm at all.
It doesn't make sense that repository:bundle-create require it to
work, also because it's not really useful for users (on the other hand
license info was not mandatory, and that's something that can always
be filled and that is definitively useful).
fabrizio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org