You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "yutannihilation (via GitHub)" <gi...@apache.org> on 2025/02/26 10:41:36 UTC
[PR] fix: Use chrono's quarter() to avoid conflict [arrow-rs]
yutannihilation opened a new pull request, #7198:
URL: https://github.com/apache/arrow-rs/pull/7198
# Which issue does this PR close?
Closes https://github.com/apache/arrow-rs/issues/7196.
# Rationale for this change
chrono now provides `.quarter()` method, and arrow's `.quarter()` is not used elsewhere than this single file. So, this pull request replaces the `.quarter()` method.
The MSRV of chrono v0.4.40 is still 1.61, so it should be fine to update to this version.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict [arrow-rs]
Posted by "haixuanTao (via GitHub)" <gi...@apache.org>.
haixuanTao commented on PR #7198:
URL: https://github.com/apache/arrow-rs/pull/7198#issuecomment-2684890645
FYI, could be cool to release a new version quickly as this makes non version locked arrow not buildable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #7198:
URL: https://github.com/apache/arrow-rs/pull/7198#issuecomment-2686734099
> Unfortunately an Apache release has a lead time of at least 3 days, and I don't have the capacity to run the ceremony at this time, although if another maintainer is happy to do so that would be an option.
Hi, the ASF allows publishing hotfixes without a three-day voting period after a public discussion, as long as someone volunteers to be the RM. That means we can release a fix as long as we have gathered three +1 binding votes.
also cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #7198:
URL: https://github.com/apache/arrow-rs/pull/7198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7198:
URL: https://github.com/apache/arrow-rs/pull/7198#issuecomment-2688184001
we have released a hotfix to crates.io
- https://github.com/apache/arrow-rs/issues/7209
The release is availale here: https://crates.io/crates/arrow/54.2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #7198:
URL: https://github.com/apache/arrow-rs/pull/7198#issuecomment-2685365216
The next release is currently scheduled for March - https://github.com/apache/arrow-rs/issues/7107
Unfortunately an Apache release has a lead time of at least 3 days, and I don't have the capacity to run the ceremony at this time, although if another maintainer is happy to do so that would be an option.
I would suggest either pinning chrono using a lockfile or an explicit dependency. It is unfortunate that chrono has released what is technically a breaking change in a patch release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7198:
URL: https://github.com/apache/arrow-rs/pull/7198#issuecomment-2687739087
FYI we are tracking this in
- https://github.com/apache/arrow-rs/issues/7107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict [arrow-rs]
Posted by "yutannihilation (via GitHub)" <gi...@apache.org>.
yutannihilation commented on PR #7198:
URL: https://github.com/apache/arrow-rs/pull/7198#issuecomment-2684609235
Ah, I was actually about to close this pull request in favor of yours! lol
Thanks for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #7198:
URL: https://github.com/apache/arrow-rs/pull/7198#discussion_r1971361294
##########
Cargo.toml:
##########
@@ -93,4 +93,4 @@ arrow-select = { version = "54.2.0", path = "./arrow-select" }
arrow-string = { version = "54.2.0", path = "./arrow-string" }
parquet = { version = "54.2.0", path = "./parquet", default-features = false }
-chrono = { version = "0.4.34", default-features = false, features = ["clock"] }
+chrono = { version = "0.4.40", default-features = false, features = ["clock"] }
Review Comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org