[jira] [Commented] (AIRFLOW-6625) Airflow should log explicitly in utf-8

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022511#comment-17022511 ] 

ASF GitHub Bot commented on AIRFLOW-6625:
-----------------------------------------

s-mcqueen commented on pull request #7247: [AIRFLOW-6625] Explicitly log using utf-8 encoding
URL: https://github.com/apache/airflow/pull/7247
 
 
   This is the standard encoding supported by Airflow. We should be explicit about logging using
   this encoding. 
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Airflow should log explicitly in utf-8
> --------------------------------------
>
>                 Key: AIRFLOW-6625
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6625
>             Project: Apache Airflow
>          Issue Type: Task
>          Components: core
>    Affects Versions: 1.10.7
>            Reporter: Sean McQueen
>            Assignee: Sean McQueen
>            Priority: Minor
>
> Currently in file_task_logger, we use a logging.FileHandler without a specified encoding. Because Airflow supports utf-8, we should be explicit here. This can prevent some environment issues where Airflow will fail in logging because of implicit encoding at this layer



--
This message was sent by Atlassian Jira
(v8.3.4#803005)