You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/06/12 07:27:05 UTC
[PR] [Pipe] Fix omitted legacy tablet compatibility follow-ups [iotdb]
Caideyipi opened a new pull request, #17929:
URL: https://github.com/apache/iotdb/pull/17929
This PR cherry-picks follow-up fixes for legacy compatibility that were missed in the previous legacy fix.
It adds legacy 1.3.x tablet batch binary request handling, hardens tablet deserialization validation/error context, and adds coverage for legacy single-column/truncated tablet cases.
Tests:
- Attempted .\mvnw.cmd -pl iotdb-core/datanode -Dtest=PipeDataNodeThriftRequestTest -DskipITs -Dspotless.check.skip=true test, but single-module compile missed reactor dependencies.
- Attempted .\mvnw.cmd -pl iotdb-core/datanode -am -Dtest=PipeDataNodeThriftRequestTest -DskipITs -Dspotless.check.skip=true -Dsurefire.failIfNoSpecifiedTests=false test, but local generated thrift compile failed because javax.annotation is unavailable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Pipe] Fix omitted legacy tablet compatibility follow-ups [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #17929:
URL: https://github.com/apache/iotdb/pull/17929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Pipe] Fix omitted legacy tablet compatibility follow-ups [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17929:
URL: https://github.com/apache/iotdb/pull/17929#issuecomment-4688667813
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17929) **Quality Gate failed**
Failed conditions
 [9.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17929&metric=new_duplicated_lines_density&view=list) (required ≤ 5%)
<!-- sqra:qg_revision=828a276ce16082820df44340a3803a0ff4ececd88efca697dbfc52ed6b83059d -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17929)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Pipe] Fix omitted legacy tablet compatibility follow-ups [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #17929:
URL: https://github.com/apache/iotdb/pull/17929#issuecomment-4689025804
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/17929?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.63717%` with `49 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.04%. Comparing base ([`aec7dfb`](https://app.codecov.io/gh/apache/iotdb/commit/aec7dfb3d61468ac880e1910e23b3a3155779d2f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e9f3c85`](https://app.codecov.io/gh/apache/iotdb/commit/e9f3c8523105238cbc0d6a88f961b687a39151b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/17929?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../evolvable/request/PipeTransferTabletBatchReq.java](https://app.codecov.io/gh/apache/iotdb/pull/17929?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Fsink%2Fpayload%2Fevolvable%2Frequest%2FPipeTransferTabletBatchReq.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9zaW5rL3BheWxvYWQvZXZvbHZhYmxlL3JlcXVlc3QvUGlwZVRyYW5zZmVyVGFibGV0QmF0Y2hSZXEuamF2YQ==) | 51.72% | [28 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17929?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...db/db/pipe/sink/util/TabletStatementConverter.java](https://app.codecov.io/gh/apache/iotdb/pull/17929?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Fsink%2Futil%2FTabletStatementConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9zaW5rL3V0aWwvVGFibGV0U3RhdGVtZW50Q29udmVydGVyLmphdmE=) | 61.70% | [18 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17929?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ad/evolvable/request/PipeTransferTabletRawReq.java](https://app.codecov.io/gh/apache/iotdb/pull/17929?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Fsink%2Fpayload%2Fevolvable%2Frequest%2FPipeTransferTabletRawReq.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9zaW5rL3BheWxvYWQvZXZvbHZhYmxlL3JlcXVlc3QvUGlwZVRyYW5zZmVyVGFibGV0UmF3UmVxLmphdmE=) | 62.50% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17929?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17929 +/- ##
=========================================
Coverage 41.04% 41.04%
Complexity 318 318
=========================================
Files 5252 5252
Lines 364388 364474 +86
Branches 47096 47115 +19
=========================================
+ Hits 149551 149604 +53
- Misses 214837 214870 +33
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/17929?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org