You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/11 04:14:34 UTC
[GitHub] [airflow] jithin97 opened a new pull request #7396: [AIRFLOW-6770]
Run particular test using breeze CLI bug fix
jithin97 opened a new pull request #7396: [AIRFLOW-6770] Run particular test using breeze CLI bug fix
URL: https://github.com/apache/airflow/pull/7396
### Description
Running a particular test from breeze CLI runs all the tests within _tests/_ directory instead of running only the tests specified by **test-target** flag
**Before:**
```
⇒ ./breeze --test-target tests/test_core.py
.
.
.
Starting the tests with those pytest arguments: tests/
======================================================================================== test session starts ========================================================================================
platform linux -- Python 3.6.10, pytest-5.3.5, py-1.8.1, pluggy-0.13.1 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, inifile: pytest.ini
plugins: requests-mock-1.7.0, cov-2.8.1, flaky-3.6.1, instafail-0.4.1.post0, celery-4.4.0
collected 5055 items / 1 skipped / 5054 selected
```
**After:**
```
⇒ ./breeze --test-target tests/test_core.py
.
.
.
Starting the tests with those pytest arguments: tests/test_core.py
======================================================================================== test session starts ========================================================================================
platform linux -- Python 3.6.10, pytest-5.3.5, py-1.8.1, pluggy-0.13.1 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, inifile: pytest.ini
plugins: requests-mock-1.7.0, cov-2.8.1, flaky-3.6.1, instafail-0.4.1.post0, celery-4.4.0
collected 24 items
```
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7396: [AIRFLOW-6770] Run
particular test using breeze CLI bug fix
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7396: [AIRFLOW-6770] Run particular test using breeze CLI bug fix
URL: https://github.com/apache/airflow/pull/7396#issuecomment-584488896
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7396?src=pr&el=h1) Report
> Merging [#7396](https://codecov.io/gh/apache/airflow/pull/7396?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/1e00243014382d4cb7152ca7c5011b97cbd733b0?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7396/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7396?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7396 +/- ##
==========================================
- Coverage 86.6% 86.46% -0.15%
==========================================
Files 873 873
Lines 40725 40725
==========================================
- Hits 35271 35213 -58
- Misses 5454 5512 +58
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7396?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7396/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0%> (-37.84%)` | :arrow_down: |
| [airflow/executors/base\_executor.py](https://codecov.io/gh/apache/airflow/pull/7396/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvYmFzZV9leGVjdXRvci5weQ==) | `93.58% <0%> (-2.57%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7396?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7396?src=pr&el=footer). Last update [1e00243...8421b26](https://codecov.io/gh/apache/airflow/pull/7396?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7396: [AIRFLOW-6770] Run
particular test using breeze CLI bug fix
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7396: [AIRFLOW-6770] Run particular test using breeze CLI bug fix
URL: https://github.com/apache/airflow/pull/7396#issuecomment-584491660
Thanks @jithin97 !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7396:
[AIRFLOW-6770] Run particular test using breeze CLI bug fix
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7396: [AIRFLOW-6770] Run particular test using breeze CLI bug fix
URL: https://github.com/apache/airflow/pull/7396#discussion_r377454766
##########
File path: scripts/ci/in_container/entrypoint_ci.sh
##########
@@ -211,6 +211,10 @@ fi
TEST_DIR="tests/"
+if [[ ${#@} -gt 0 && -n "$1" ]]; then
+ TEST_DIR="$1"
+fi
+
if [[ -n ${RUNTIME} ]]; then
CI_ARGS+=("--runtime" "${RUNTIME}" "-rpfExX")
TEST_DIR="tests/runtime"
Review comment:
```suggestion
TESTS_TO_RUN="tests/runtime"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7396:
[AIRFLOW-6770] Run particular test using breeze CLI bug fix
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7396: [AIRFLOW-6770] Run particular test using breeze CLI bug fix
URL: https://github.com/apache/airflow/pull/7396#discussion_r377454608
##########
File path: scripts/ci/in_container/entrypoint_ci.sh
##########
@@ -211,6 +211,10 @@ fi
TEST_DIR="tests/"
Review comment:
```suggestion
TESTS_TO_RUN="tests/"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] jithin97 commented on a change in pull request #7396:
[AIRFLOW-6770] Run particular test using breeze CLI bug fix
Posted by GitBox <gi...@apache.org>.
jithin97 commented on a change in pull request #7396: [AIRFLOW-6770] Run particular test using breeze CLI bug fix
URL: https://github.com/apache/airflow/pull/7396#discussion_r377459173
##########
File path: .travis.yml
##########
@@ -101,7 +101,7 @@ jobs:
ENABLED_INTEGRATIONS="cassandra kerberos mongo openldap rabbitmq redis"
RUN_INTEGRATION_TESTS=all
stage: test
- script: ./scripts/ci/ci_run_airflow_testing.sh tests/tests_core.py
+ script: ./scripts/ci/ci_run_airflow_testing.sh tests/test_core.py
Review comment:
fixed!!! https://github.com/apache/airflow/pull/7396/commits/f6be34fd8725ae44b156f0e51076d92bf69a36a0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] jithin97 commented on a change in pull request #7396:
[AIRFLOW-6770] Run particular test using breeze CLI bug fix
Posted by GitBox <gi...@apache.org>.
jithin97 commented on a change in pull request #7396: [AIRFLOW-6770] Run particular test using breeze CLI bug fix
URL: https://github.com/apache/airflow/pull/7396#discussion_r377459152
##########
File path: scripts/ci/in_container/entrypoint_ci.sh
##########
@@ -211,6 +211,10 @@ fi
TEST_DIR="tests/"
Review comment:
fixed!!! https://github.com/apache/airflow/pull/7396/commits/f6be34fd8725ae44b156f0e51076d92bf69a36a0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7396:
[AIRFLOW-6770] Run particular test using breeze CLI bug fix
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7396: [AIRFLOW-6770] Run particular test using breeze CLI bug fix
URL: https://github.com/apache/airflow/pull/7396#discussion_r377454957
##########
File path: scripts/ci/in_container/entrypoint_ci.sh
##########
@@ -211,6 +211,10 @@ fi
TEST_DIR="tests/"
+if [[ ${#@} -gt 0 && -n "$1" ]]; then
+ TEST_DIR="$1"
+fi
+
if [[ -n ${RUNTIME} ]]; then
CI_ARGS+=("--runtime" "${RUNTIME}" "-rpfExX")
TEST_DIR="tests/runtime"
Review comment:
And also we should change TEST_DIR below to TESTS_TO_RUN :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] jithin97 commented on a change in pull request #7396:
[AIRFLOW-6770] Run particular test using breeze CLI bug fix
Posted by GitBox <gi...@apache.org>.
jithin97 commented on a change in pull request #7396: [AIRFLOW-6770] Run particular test using breeze CLI bug fix
URL: https://github.com/apache/airflow/pull/7396#discussion_r377459124
##########
File path: scripts/ci/in_container/entrypoint_ci.sh
##########
@@ -211,6 +211,10 @@ fi
TEST_DIR="tests/"
+if [[ ${#@} -gt 0 && -n "$1" ]]; then
+ TEST_DIR="$1"
+fi
+
if [[ -n ${RUNTIME} ]]; then
CI_ARGS+=("--runtime" "${RUNTIME}" "-rpfExX")
TEST_DIR="tests/runtime"
Review comment:
fixed!!! https://github.com/apache/airflow/pull/7396/commits/f6be34fd8725ae44b156f0e51076d92bf69a36a0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7396:
[AIRFLOW-6770] Run particular test using breeze CLI bug fix
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7396: [AIRFLOW-6770] Run particular test using breeze CLI bug fix
URL: https://github.com/apache/airflow/pull/7396#discussion_r377454669
##########
File path: scripts/ci/in_container/entrypoint_ci.sh
##########
@@ -211,6 +211,10 @@ fi
TEST_DIR="tests/"
Review comment:
I think this will be better name :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7396:
[AIRFLOW-6770] Run particular test using breeze CLI bug fix
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7396: [AIRFLOW-6770] Run particular test using breeze CLI bug fix
URL: https://github.com/apache/airflow/pull/7396#discussion_r377454371
##########
File path: .travis.yml
##########
@@ -101,7 +101,7 @@ jobs:
ENABLED_INTEGRATIONS="cassandra kerberos mongo openldap rabbitmq redis"
RUN_INTEGRATION_TESTS=all
stage: test
- script: ./scripts/ci/ci_run_airflow_testing.sh tests/tests_core.py
+ script: ./scripts/ci/ci_run_airflow_testing.sh tests/test_core.py
Review comment:
```suggestion
```
That's an interesting one. Actually it's a mistake here. We should not constraint ourselves in this test only to test_core. It is likely a remnant from some testing done when I was implementing it. Good that you noticed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin merged pull request #7396: [AIRFLOW-6770]
Run particular test using breeze CLI bug fix
Posted by GitBox <gi...@apache.org>.
nuclearpinguin merged pull request #7396: [AIRFLOW-6770] Run particular test using breeze CLI bug fix
URL: https://github.com/apache/airflow/pull/7396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services