You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rayees Namathponnan <ra...@citrix.com> on 2014/10/07 06:06:32 UTC

Review Request 26404: Usage server failed to start if default java version is 1.6

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26404/
-----------------------------------------------------------

Review request for cloudstack and Frank Zhang.


Bugs: CLOUDSTACK-7676
    https://issues.apache.org/jira/browse/CLOUDSTACK-7676


Repository: cloudstack-git


Description
-------

Install usage server on RHEL 6.3 machine
check default. java version
start usage server


Result
If default java versionis java 1.6, then management serer will fails to start

Solution
While starting usage server, we need to check java 1.7 exist or not, if exist then we need to start usage server with java 1.7


Diffs
-----

  packaging/centos63/cloud-usage.rc 7741137 

Diff: https://reviews.apache.org/r/26404/diff/


Testing
-------

Tested


Thanks,

Rayees Namathponnan


Re: Review Request 26404: Usage server failed to start if default java version is 1.6

Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26404/#review79010
-----------------------------------------------------------


Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.

We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).

Please consider submitting a pull request.

Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md

Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.

- Sebastien Goasguen


On Oct. 7, 2014, 4:06 a.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26404/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2014, 4:06 a.m.)
> 
> 
> Review request for cloudstack and Frank Zhang.
> 
> 
> Bugs: CLOUDSTACK-7676
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7676
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Install usage server on RHEL 6.3 machine
> check default. java version
> start usage server
> 
> 
> Result
> If default java versionis java 1.6, then management serer will fails to start
> 
> Solution
> While starting usage server, we need to check java 1.7 exist or not, if exist then we need to start usage server with java 1.7
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud-usage.rc 7741137 
> 
> Diff: https://reviews.apache.org/r/26404/diff/
> 
> 
> Testing
> -------
> 
> Tested
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>


Re: Review Request 26404: Usage server failed to start if default java version is 1.6

Posted by Pierre-Luc Dion <pd...@apache.org>.

> On Oct. 7, 2014, 7:08 a.m., Rajani Karuturi wrote:
> > Hi Rayees,
> > I think hardcoding the jdk dir isnt right. Can you please fix this as per the discussion on the other thread? RR: https://reviews.apache.org/r/25289/ mail thread: http://markmail.org/message/eun6jlgd4c27km3b

Rajani, can you confirm this Review request as been process, I see fixes in 4.5 related to this issue. 

Thanks,


- Pierre-Luc


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26404/#review55632
-----------------------------------------------------------


On Oct. 7, 2014, 4:06 a.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26404/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2014, 4:06 a.m.)
> 
> 
> Review request for cloudstack and Frank Zhang.
> 
> 
> Bugs: CLOUDSTACK-7676
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7676
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Install usage server on RHEL 6.3 machine
> check default. java version
> start usage server
> 
> 
> Result
> If default java versionis java 1.6, then management serer will fails to start
> 
> Solution
> While starting usage server, we need to check java 1.7 exist or not, if exist then we need to start usage server with java 1.7
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud-usage.rc 7741137 
> 
> Diff: https://reviews.apache.org/r/26404/diff/
> 
> 
> Testing
> -------
> 
> Tested
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>


Re: Review Request 26404: Usage server failed to start if default java version is 1.6

Posted by Rajani Karuturi <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26404/#review55632
-----------------------------------------------------------


Hi Rayees,
I think hardcoding the jdk dir isnt right. Can you please fix this as per the discussion on the other thread? RR: https://reviews.apache.org/r/25289/ mail thread: http://markmail.org/message/eun6jlgd4c27km3b

- Rajani Karuturi


On Oct. 7, 2014, 4:06 a.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26404/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2014, 4:06 a.m.)
> 
> 
> Review request for cloudstack and Frank Zhang.
> 
> 
> Bugs: CLOUDSTACK-7676
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7676
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Install usage server on RHEL 6.3 machine
> check default. java version
> start usage server
> 
> 
> Result
> If default java versionis java 1.6, then management serer will fails to start
> 
> Solution
> While starting usage server, we need to check java 1.7 exist or not, if exist then we need to start usage server with java 1.7
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud-usage.rc 7741137 
> 
> Diff: https://reviews.apache.org/r/26404/diff/
> 
> 
> Testing
> -------
> 
> Tested
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>