You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openoffice.apache.org by pe...@apache.org on 2026/08/29 11:59:19 UTC
(openoffice) 16/17: sal: unicows.lib is x86 only, so do not name it in the x64 uwinapi link
This is an automated email from the ASF dual-hosted git repository.
leginee pushed a commit to branch win10-msvc-trunk
in repository https://gitbox.apache.org/repos/asf/openoffice.git
commit c61357cda581f9001185f8cbad0ec01632647397
Author: Peter Kovacs <pe...@apache.org>
AuthorDate: Sat Aug 29 13:54:25 2026 +0200
sal: unicows.lib is x86 only, so do not name it in the x64 uwinapi link
unicows.lib is the import library for the Microsoft Layer for Unicode, and
the SDK ships it for x86 alone. Naming it unconditionally fails the x64
link outright:
LINK : fatal error LNK1181: cannot open input file 'unicows.lib'
Nothing is lost by dropping it there. MSLU exists to give Windows 9x the
wide APIs, a platform that has no 64-bit edition; on x64 SLOFILES carries
none of the thunks that would wrap it and the export list is uwinapi64.dxp
alone, so there is nothing left to resolve against it.
Guard on CPUNAME rather than removing the line, so the x86 link is
byte-for-byte what it was.
Co-Authored-By: Claude Opus 5 <no...@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UWgzQY2r1XwFvgeLPFWPsi
---
main/sal/systools/win32/uwinapi/makefile.mk | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/main/sal/systools/win32/uwinapi/makefile.mk b/main/sal/systools/win32/uwinapi/makefile.mk
index cd1c8ea337..d81a02fa02 100644
--- a/main/sal/systools/win32/uwinapi/makefile.mk
+++ b/main/sal/systools/win32/uwinapi/makefile.mk
@@ -145,8 +145,16 @@ SHL1STDLIBS=\
MINGWSSTDOBJ=
MINGWSSTDENDOBJ=
.ELSE
+# unicows.lib is the Microsoft Layer for Unicode, and only the x86 build wraps
+# anything from it: on x64 SLOFILES carries none of the MSLU thunks and the
+# export list is uwinapi64.dxp alone. The SDK ships the import library for
+# x86 only, so naming it here breaks the x64 link with LNK1181.
+.IF "$(CPUNAME)"=="INTEL"
SHL1STDLIBS=\
unicows.lib
+.ELSE
+SHL1STDLIBS=
+.ENDIF
.ENDIF
SHL1STDLIBS+=\