[jira] [Commented] (OAK-4477) RDBDatasourceFactory should use pool config similar to sling datasource defaults

["Julian Reschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334011#comment-15334011 ] 

Julian Reschke commented on OAK-4477:
-------------------------------------

trunk: http://svn.apache.org/r1748747 http://svn.apache.org/r1748714
1.4: http://svn.apache.org/r1748748 http://svn.apache.org/r1748737


> RDBDatasourceFactory should use pool config similar to sling datasource defaults
> --------------------------------------------------------------------------------
>
>                 Key: OAK-4477
>                 URL: https://issues.apache.org/jira/browse/OAK-4477
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: rdbmk
>    Affects Versions: 1.0.31, 1.4.3, 1.5.3, 1.2.16
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>              Labels: candidate_oak_1_0, candidate_oak_1_2
>             Fix For: 1.5.4, 1.4.4
>
>
> {{RDBDataSourceFactory}} is used only for testing, and creates instances of {{org.apache.tomcat.jdbc.pool.DataSource}}.
> These are currently created with default config, while {{org.apache.sling.datasource}} (which is likely used in production) uses it's own defaults. In particular, it configures three interceptors -- {{StatementCache;SlowQueryReport(threshold=10000);ConnectionState}} -- which we do not, thus they aren't getting unit test coverage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)