You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/13 23:12:02 UTC
[GitHub] [airflow] quentin-bayart opened a new pull request #12355: add ability to import dags in a subfolder with a zip file
quentin-bayart opened a new pull request #12355:
URL: https://github.com/apache/airflow/pull/12355
At Nielsen our data scientists write complex models using Airflow dags. Most of their projects follows this structure:
```
model-xyz
├── __init__.py
├── config.yaml
├── dag
│ ├── __init__.py
│ ├── dag.py
│ └── lib
│ ├── __init__.py
...
│ └── my_module.py
├── job_request.yaml
└── tests
├── __init__.py
└── test_lib
├── __init__.py
├── test.yaml
...
└── test_my_module.py
```
Each model has a dedicated team working on it, is its own git repo and is edited through an IDE. When editing the project, our users may use relative imports and they usually have a root dir (here "model-xyz"). They then use a cli tool to zip their projects and send them to the dag home of our Airflow instance. We don't want to change the project structure when zipping it.
This PR allows us to parse dag objects nested inside sub-folders. It is backwards compatible with the default value and allows for more customization. Some airflow dag projects at Nielsen contain hundreds of python files including tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12355: add ability to import dags in a subfolder with a zip file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12355:
URL: https://github.com/apache/airflow/pull/12355#issuecomment-787209809
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #12355: add ability to import dags in a subfolder with a zip file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #12355:
URL: https://github.com/apache/airflow/pull/12355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] quentin-bayart edited a comment on pull request #12355: add ability to import dags in a subfolder with a zip file
Posted by GitBox <gi...@apache.org>.
quentin-bayart edited a comment on pull request #12355:
URL: https://github.com/apache/airflow/pull/12355#issuecomment-729208581
I think "connection lost" is the reason why the check failed. This does not seem related to my changes, any recommendations for this error?
`*** Running /container/run/process/slapd/run...
5fb410bd @(#) $OpenLDAP: slapd 2.4.50+dfsg-1~bpo10+1 (May 4 2020 05:25:06) $
Debian OpenLDAP Maintainers <pk...@lists.alioth.debian.org>
5fb410bd slapd starting
5fb410d1 conn=1000 fd=12 ACCEPT from IP=172.25.0.8:33880 (IP=0.0.0.0:389)
5fb410d1 conn=1000 fd=12 closed (connection lost)
Container docker-compose_openldap_1 logs dumped to /home/runner/work/airflow/airflow/files/container_logs_docker-compose_openldap_1_2020-11-17_368580125_tests-postgres.log
###########################################################################################
###########################################################################################
EXITING WITH STATUS CODE 1
###########################################################################################
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12355: add ability to import dags in a subfolder with a zip file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12355:
URL: https://github.com/apache/airflow/pull/12355#issuecomment-729036466
[The Workflow run](https://github.com/apache/airflow/actions/runs/368485212) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12355: add ability to import dags in a subfolder with a zip file
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #12355:
URL: https://github.com/apache/airflow/pull/12355#issuecomment-727079142
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] quentin-bayart commented on pull request #12355: add ability to import dags in a subfolder with a zip file
Posted by GitBox <gi...@apache.org>.
quentin-bayart commented on pull request #12355:
URL: https://github.com/apache/airflow/pull/12355#issuecomment-729208581
I think "connection lost" is the reason why the check failed. This does not seem related to my changes, any recommendations for this error?
`*** Running /container/run/process/slapd/run...
5fb410bd @(#) $OpenLDAP: slapd 2.4.50+dfsg-1~bpo10+1 (May 4 2020 05:25:06) $
Debian OpenLDAP Maintainers <pk...@lists.alioth.debian.org>
5fb410bd slapd starting
5fb410d1 conn=1000 fd=12 ACCEPT from IP=172.25.0.8:33880 (IP=0.0.0.0:389)
5fb410d1 conn=1000 fd=12 closed (connection lost)
Container docker-compose_openldap_1 logs dumped to /home/runner/work/airflow/airflow/files/container_logs_docker-compose_openldap_1_2020-11-17_368580125_tests-postgres.log
###########################################################################################
###########################################################################################
EXITING WITH STATUS CODE 1
###########################################################################################`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] quentin-bayart edited a comment on pull request #12355: add ability to import dags in a subfolder with a zip file
Posted by GitBox <gi...@apache.org>.
quentin-bayart edited a comment on pull request #12355:
URL: https://github.com/apache/airflow/pull/12355#issuecomment-729208581
I think "connection lost" is the reason why the check failed. This does not seem related to my changes, any recommendations for this error?
````
*** Running /container/run/process/slapd/run...
5fb410bd @(#) $OpenLDAP: slapd 2.4.50+dfsg-1~bpo10+1 (May 4 2020 05:25:06) $
Debian OpenLDAP Maintainers <pk...@lists.alioth.debian.org>
5fb410bd slapd starting
5fb410d1 conn=1000 fd=12 ACCEPT from IP=172.25.0.8:33880 (IP=0.0.0.0:389)
5fb410d1 conn=1000 fd=12 closed (connection lost)
Container docker-compose_openldap_1 logs dumped to /home/runner/work/airflow/airflow/files/container_logs_docker-compose_openldap_1_2020-11-17_368580125_tests-postgres.log
###########################################################################################
###########################################################################################
EXITING WITH STATUS CODE 1
###########################################################################################
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12355: add ability to import dags in a subfolder with a zip file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12355:
URL: https://github.com/apache/airflow/pull/12355#issuecomment-727086244
[The Workflow run](https://github.com/apache/airflow/actions/runs/362503890) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12355: add ability to import dags in a subfolder with a zip file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12355:
URL: https://github.com/apache/airflow/pull/12355#issuecomment-729035765
[The Workflow run](https://github.com/apache/airflow/actions/runs/368483056) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org