You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/04/01 04:40:26 UTC
Re: Review Request 58128: Windows: Updated use of UTF-16
`getSystemEnvironment`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58128/
-----------------------------------------------------------
(Updated April 1, 2017, 4:40 a.m.)
Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
Changes
-------
Update test results.
Repository: mesos
Description
-------
The containerizer needs to convert UTF-16 values and keys to UTF-8, but
this is trivial with the updated `stringify`.
Diffs
-----
src/slave/containerizer/docker.cpp ad9ab847cb3093724ef374d036c896b4e7f18b5e
src/slave/containerizer/mesos/launch.cpp 395394f04982a7df58e32e9aeebb63756e85b89b
Diff: https://reviews.apache.org/r/58128/diff/1/
Testing (updated)
-------
# Linux
```
[==========] 1531 tests from 173 test cases ran. (448806 ms total)
[ PASSED ] 1530 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] LdcacheTest.Parse
```
Unrelated failure (probably).
# Windows
## stout-tests
```
[----------] Global test environment tear-down
[==========] 230 tests from 39 test cases ran. (4456 ms total)
[ PASSED ] 228 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] Base64Test.EncodeURLSafe
[ FAILED ] Base64Test.DecodeURLSafe
```
* These are [known failures](https://issues.apache.org/jira/browse/MESOS-7236).
## libprocess-tests
```
[----------] Global test environment tear-down
[==========] 116 tests from 26 test cases ran. (10889 ms total)
[ PASSED ] 116 tests.
```
## mesos-tests
```
[==========] 559 tests from 58 test cases ran. (8886776 ms total)
[ PASSED ] 556 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] HealthCheckTest.HealthyTaskNonShell
[ FAILED ] CombinedAuthenticatorTest.MultipleAuthenticators
[ FAILED ] CopyFetcherPluginTest.FetchExistingFile
```
* The `FetchExistingFile` is a [known failure](https://issues.apache.org/jira/browse/MESOS-7311).
* The `HealthyTaskNonShell` I'm currently debugging (something seems off about the definition of `TRUE_COMMAND` on Windows and its use in a `NonShell` test).
* I haven't quite looked at `MultipleAuthenticators` yet.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 58128: Windows: Updated use of UTF-16
`getSystemEnvironment`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58128/#review171059
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On April 3, 2017, 10:54 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58128/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 10:54 a.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
>
>
> Bugs: MESOS-5418
> https://issues.apache.org/jira/browse/MESOS-5418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The containerizer needs to convert UTF-16 values and keys to UTF-8, but
> this is trivial with the updated `stringify`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp ad9ab847cb3093724ef374d036c896b4e7f18b5e
> src/slave/containerizer/mesos/launch.cpp 395394f04982a7df58e32e9aeebb63756e85b89b
>
>
> Diff: https://reviews.apache.org/r/58128/diff/1/
>
>
> Testing
> -------
>
> # Linux
>
> ```
> [==========] 1531 tests from 173 test cases ran. (448806 ms total)
> [ PASSED ] 1530 tests.
> [ FAILED ] 1 test, listed below:
> [ FAILED ] LdcacheTest.Parse
> ```
>
> Unrelated failure (fails for me on master too, so just a box issue, not introduced by these changes).
>
> # Windows
>
> ## stout-tests
>
> ```
> [----------] Global test environment tear-down
> [==========] 230 tests from 39 test cases ran. (4456 ms total)
> [ PASSED ] 228 tests.
> [ FAILED ] 2 tests, listed below:
> [ FAILED ] Base64Test.EncodeURLSafe
> [ FAILED ] Base64Test.DecodeURLSafe
> ```
>
> * These are [known failures](https://issues.apache.org/jira/browse/MESOS-7236).
>
> ## libprocess-tests
>
> ```
> [----------] Global test environment tear-down
> [==========] 116 tests from 26 test cases ran. (10889 ms total)
> [ PASSED ] 116 tests.
> ```
>
> ## mesos-tests
>
> ```
> [==========] 559 tests from 58 test cases ran. (8886776 ms total)
> [ PASSED ] 556 tests.
> [ FAILED ] 3 tests, listed below:
> [ FAILED ] HealthCheckTest.HealthyTaskNonShell
> [ FAILED ] CombinedAuthenticatorTest.MultipleAuthenticators
> [ FAILED ] CopyFetcherPluginTest.FetchExistingFile
> ```
>
> * The `FetchExistingFile` is a [known failure](https://issues.apache.org/jira/browse/MESOS-7311).
> * The `HealthyTaskNonShell` I'm currently debugging (something seems off about the definition of `TRUE_COMMAND` on Windows and its use in a `NonShell` test).
> * The `MultipleAuthenticators` test fails for me on `master` too (spefically e37442578), so it's probably a machine configuration issue, but was not introduced by these changes.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 58128: Windows: Updated use of UTF-16
`getSystemEnvironment`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58128/#review171065
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On April 3, 2017, 10:54 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58128/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 10:54 a.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
>
>
> Bugs: MESOS-5418
> https://issues.apache.org/jira/browse/MESOS-5418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The containerizer needs to convert UTF-16 values and keys to UTF-8, but
> this is trivial with the updated `stringify`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp ad9ab847cb3093724ef374d036c896b4e7f18b5e
> src/slave/containerizer/mesos/launch.cpp 395394f04982a7df58e32e9aeebb63756e85b89b
>
>
> Diff: https://reviews.apache.org/r/58128/diff/1/
>
>
> Testing
> -------
>
> # Linux
>
> ```
> [==========] 1531 tests from 173 test cases ran. (448806 ms total)
> [ PASSED ] 1530 tests.
> [ FAILED ] 1 test, listed below:
> [ FAILED ] LdcacheTest.Parse
> ```
>
> Unrelated failure (fails for me on master too, so just a box issue, not introduced by these changes).
>
> # Windows
>
> ## stout-tests
>
> ```
> [----------] Global test environment tear-down
> [==========] 230 tests from 39 test cases ran. (4456 ms total)
> [ PASSED ] 228 tests.
> [ FAILED ] 2 tests, listed below:
> [ FAILED ] Base64Test.EncodeURLSafe
> [ FAILED ] Base64Test.DecodeURLSafe
> ```
>
> * These are [known failures](https://issues.apache.org/jira/browse/MESOS-7236).
>
> ## libprocess-tests
>
> ```
> [----------] Global test environment tear-down
> [==========] 116 tests from 26 test cases ran. (10889 ms total)
> [ PASSED ] 116 tests.
> ```
>
> ## mesos-tests
>
> ```
> [==========] 559 tests from 58 test cases ran. (8886776 ms total)
> [ PASSED ] 556 tests.
> [ FAILED ] 3 tests, listed below:
> [ FAILED ] HealthCheckTest.HealthyTaskNonShell
> [ FAILED ] CombinedAuthenticatorTest.MultipleAuthenticators
> [ FAILED ] CopyFetcherPluginTest.FetchExistingFile
> ```
>
> * The `FetchExistingFile` is a [known failure](https://issues.apache.org/jira/browse/MESOS-7311).
> * The `HealthyTaskNonShell` I'm currently debugging (something seems off about the definition of `TRUE_COMMAND` on Windows and its use in a `NonShell` test).
> * The `MultipleAuthenticators` test fails for me on `master` too (spefically e37442578), so it's probably a machine configuration issue, but was not introduced by these changes.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 58128: Windows: Updated use of UTF-16
`getSystemEnvironment`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58128/
-----------------------------------------------------------
(Updated April 3, 2017, 5:54 p.m.)
Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
Repository: mesos
Description
-------
The containerizer needs to convert UTF-16 values and keys to UTF-8, but
this is trivial with the updated `stringify`.
Diffs
-----
src/slave/containerizer/docker.cpp ad9ab847cb3093724ef374d036c896b4e7f18b5e
src/slave/containerizer/mesos/launch.cpp 395394f04982a7df58e32e9aeebb63756e85b89b
Diff: https://reviews.apache.org/r/58128/diff/1/
Testing (updated)
-------
# Linux
```
[==========] 1531 tests from 173 test cases ran. (448806 ms total)
[ PASSED ] 1530 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] LdcacheTest.Parse
```
Unrelated failure (fails for me on master too, so just a box issue, not introduced by these changes).
# Windows
## stout-tests
```
[----------] Global test environment tear-down
[==========] 230 tests from 39 test cases ran. (4456 ms total)
[ PASSED ] 228 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] Base64Test.EncodeURLSafe
[ FAILED ] Base64Test.DecodeURLSafe
```
* These are [known failures](https://issues.apache.org/jira/browse/MESOS-7236).
## libprocess-tests
```
[----------] Global test environment tear-down
[==========] 116 tests from 26 test cases ran. (10889 ms total)
[ PASSED ] 116 tests.
```
## mesos-tests
```
[==========] 559 tests from 58 test cases ran. (8886776 ms total)
[ PASSED ] 556 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] HealthCheckTest.HealthyTaskNonShell
[ FAILED ] CombinedAuthenticatorTest.MultipleAuthenticators
[ FAILED ] CopyFetcherPluginTest.FetchExistingFile
```
* The `FetchExistingFile` is a [known failure](https://issues.apache.org/jira/browse/MESOS-7311).
* The `HealthyTaskNonShell` I'm currently debugging (something seems off about the definition of `TRUE_COMMAND` on Windows and its use in a `NonShell` test).
* The `MultipleAuthenticators` test fails for me on `master` too (spefically e37442578), so it's probably a machine configuration issue, but was not introduced by these changes.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 58128: Windows: Updated use of UTF-16
`getSystemEnvironment`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58128/
-----------------------------------------------------------
(Updated April 3, 2017, 5:35 p.m.)
Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
Repository: mesos
Description
-------
The containerizer needs to convert UTF-16 values and keys to UTF-8, but
this is trivial with the updated `stringify`.
Diffs
-----
src/slave/containerizer/docker.cpp ad9ab847cb3093724ef374d036c896b4e7f18b5e
src/slave/containerizer/mesos/launch.cpp 395394f04982a7df58e32e9aeebb63756e85b89b
Diff: https://reviews.apache.org/r/58128/diff/1/
Testing (updated)
-------
# Linux
```
[==========] 1531 tests from 173 test cases ran. (448806 ms total)
[ PASSED ] 1530 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] LdcacheTest.Parse
```
Unrelated failure (probably).
# Windows
## stout-tests
```
[----------] Global test environment tear-down
[==========] 230 tests from 39 test cases ran. (4456 ms total)
[ PASSED ] 228 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] Base64Test.EncodeURLSafe
[ FAILED ] Base64Test.DecodeURLSafe
```
* These are [known failures](https://issues.apache.org/jira/browse/MESOS-7236).
## libprocess-tests
```
[----------] Global test environment tear-down
[==========] 116 tests from 26 test cases ran. (10889 ms total)
[ PASSED ] 116 tests.
```
## mesos-tests
```
[==========] 559 tests from 58 test cases ran. (8886776 ms total)
[ PASSED ] 556 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] HealthCheckTest.HealthyTaskNonShell
[ FAILED ] CombinedAuthenticatorTest.MultipleAuthenticators
[ FAILED ] CopyFetcherPluginTest.FetchExistingFile
```
* The `FetchExistingFile` is a [known failure](https://issues.apache.org/jira/browse/MESOS-7311).
* The `HealthyTaskNonShell` I'm currently debugging (something seems off about the definition of `TRUE_COMMAND` on Windows and its use in a `NonShell` test).
* The `MultipleAuthenticators` test fails for me on `master` too (spefically e37442578), so it's probably a machine configuration issue, but was not introduced by these changes.
Thanks,
Andrew Schwartzmeyer