You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kgyrtkirk (via GitHub)" <gi...@apache.org> on 2025/02/21 19:17:20 UTC

[PR] Refactor MSQSpec usages to reduce reliance on the native query (druid)

kgyrtkirk opened a new pull request, #17753:
URL: https://github.com/apache/druid/pull/17753

   This is a preparation refactor to step in the direction of moving the production point of the staged plan more closer to when the task is submitted.
   This change:
   * reduces the usages of the `MSQSpec#getQuery` usages as much as possible
   * remove usages of `MSQSpec` during the querykit planning phase
   * moved the top level QueryKit related planning code out from the `ControllerImpl` class into a standalone class
   * lots of minor changes to use `MSQSpec#getContext` instead of `MSQSpec.getQuery().getContext()`
   
   This change was produced with refactoring steps only - so it should work just like the old code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Refactor MSQSpec usages to reduce reliance on the native query (druid)

Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on PR #17753:
URL: https://github.com/apache/druid/pull/17753#issuecomment-2677988978

   Thank you @adarshsanjeev for reviewing the changes!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Refactor MSQSpec usages to reduce reliance on the native query (druid)

Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk merged PR #17753:
URL: https://github.com/apache/druid/pull/17753


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org