You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/22 17:56:17 UTC
[GitHub] [pulsar] ericsyh opened a new pull request #12927: feat(cli): support sql-worker in pulsar-daemon
ericsyh opened a new pull request #12927:
URL: https://github.com/apache/pulsar/pull/12927
Signed-off-by: Eric Shen <er...@outlook.com>
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
Pulsar sql-worker only supports in pulsar shell cli and not support in pulsar-daemon. So, users have to open two terminals to use pulsar sql, one for sql-worker and one for sql-cli.
### Modifications
I changed the pulsar shell cli and pulsar-daemon shell cli to support sql-worker in pulsar-daemon.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #12927: feat(cli): support sql-worker in pulsar-daemon
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #12927:
URL: https://github.com/apache/pulsar/pull/12927#issuecomment-978770437
@ericsyh You can try `bin/pulsar sql-worker start`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #12927: feat(cli): support sql-worker in pulsar-daemon
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #12927:
URL: https://github.com/apache/pulsar/pull/12927#issuecomment-976631512
It will break the current pulsar sql worker startup action, please take a look @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on pull request #12927: feat(cli): support sql-worker in pulsar-daemon
Posted by GitBox <gi...@apache.org>.
ericsyh commented on pull request #12927:
URL: https://github.com/apache/pulsar/pull/12927#issuecomment-976100116
@Anonymitaet If this PR merged, the command of start a Pulsar SQL worker should be updated. I changed the start command from `./bin/pulsar sql-worker run` to `./bin/pulsar sql-worker` and also support the daemon in `./bin/pulsar-daemon start sql-worker` https://pulsar.apache.org/docs/en/sql-getting-started/#query-data-in-pulsar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on pull request #12927: feat(cli): support sql-worker in pulsar-daemon
Posted by GitBox <gi...@apache.org>.
ericsyh commented on pull request #12927:
URL: https://github.com/apache/pulsar/pull/12927#issuecomment-978809237
> @ericsyh You can try `bin/pulsar sql-worker start`
This works to run sql-worker in daemon. But it really confusing for sql-worker actually.... while other components are all use `pulsar-damon` to start in daemon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #12927: feat(cli): support sql-worker in pulsar-daemon
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #12927:
URL: https://github.com/apache/pulsar/pull/12927#issuecomment-976134131
@ericsyh thanks for your explanations! Then can you update docs [here](https://pulsar.apache.org/docs/en/next/reference-cli-tools/#pulsar) and [here](https://pulsar.apache.org/docs/en/sql-getting-started/#query-data-in-pulsar)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #12927: feat(cli): support sql-worker in pulsar-daemon
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #12927:
URL: https://github.com/apache/pulsar/pull/12927#issuecomment-976071059
@ericsyh need to add docs [here](https://pulsar.apache.org/docs/en/next/reference-cli-tools/#pulsar-daemon)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh closed pull request #12927: feat(cli): support sql-worker in pulsar-daemon
Posted by GitBox <gi...@apache.org>.
ericsyh closed pull request #12927:
URL: https://github.com/apache/pulsar/pull/12927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on pull request #12927: feat(cli): support sql-worker in pulsar-daemon
Posted by GitBox <gi...@apache.org>.
ericsyh commented on pull request #12927:
URL: https://github.com/apache/pulsar/pull/12927#issuecomment-976224810
Sure, i will update the doc. But seems i need some help on the CI, my changes won't impact on broker UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org