You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/10/03 23:15:41 UTC
Review Request 26329: Split messages_launch_tasks into
messages_launch_tasks and messages_decline_offers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26329/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1863
https://issues.apache.org/jira/browse/MESOS-1863
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f
src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e
Diff: https://reviews.apache.org/r/26329/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 26329: Split messages_launch_tasks into
messages_launch_tasks and messages_decline_offers.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26329/#review55409
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26329]
All tests passed.
- Mesos ReviewBot
On Oct. 3, 2014, 9:15 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26329/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 9:15 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1863
> https://issues.apache.org/jira/browse/MESOS-1863
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f
> src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e
>
> Diff: https://reviews.apache.org/r/26329/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 26329: Split messages_launch_tasks into
messages_launch_tasks and messages_decline_offers.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26329/#review55397
-----------------------------------------------------------
src/master/master.cpp
<https://reviews.apache.org/r/26329/#comment95751>
if (tasks.empty()) ?
src/master/master.cpp
<https://reviews.apache.org/r/26329/#comment95752>
if we still have the test that checks for which metrics are available on master, you should update it.
- Dominic Hamon
On Oct. 3, 2014, 2:15 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26329/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 2:15 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1863
> https://issues.apache.org/jira/browse/MESOS-1863
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f
> src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e
>
> Diff: https://reviews.apache.org/r/26329/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 26329: Split messages_launch_tasks into
messages_launch_tasks and messages_decline_offers.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26329/#review55557
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26329]
All tests passed.
- Mesos ReviewBot
On Oct. 6, 2014, 6:20 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26329/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 6:20 p.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Bugs: MESOS-1863
> https://issues.apache.org/jira/browse/MESOS-1863
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f
> src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e
> src/tests/master_tests.cpp 705e5f2c0f9d693946e722cef63f38f3bff0d46b
>
> Diff: https://reviews.apache.org/r/26329/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 26329: Split messages_launch_tasks into
messages_launch_tasks and messages_decline_offers.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26329/#review55545
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Oct. 6, 2014, 11:20 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26329/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 11:20 a.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Bugs: MESOS-1863
> https://issues.apache.org/jira/browse/MESOS-1863
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f
> src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e
> src/tests/master_tests.cpp 705e5f2c0f9d693946e722cef63f38f3bff0d46b
>
> Diff: https://reviews.apache.org/r/26329/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 26329: Split messages_launch_tasks into
messages_launch_tasks and messages_decline_offers.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26329/
-----------------------------------------------------------
(Updated Oct. 6, 2014, 6:20 p.m.)
Review request for mesos, Ben Mahler and Dominic Hamon.
Changes
-------
added reviewers. dominic's comments.
Bugs: MESOS-1863
https://issues.apache.org/jira/browse/MESOS-1863
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f
src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e
src/tests/master_tests.cpp 705e5f2c0f9d693946e722cef63f38f3bff0d46b
Diff: https://reviews.apache.org/r/26329/diff/
Testing
-------
make check
Thanks,
Vinod Kone