You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/04 14:51:48 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #13462: chore: Removes Popover duplication
michael-s-molina opened a new pull request #13462:
URL: https://github.com/apache/superset/pull/13462
### SUMMARY
Removes `Popover` duplication.
### TEST PLAN
1 - Execute all tests.
2 - All tests should pass.
@rusackas
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13462: chore: Removes Popover duplication
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13462:
URL: https://github.com/apache/superset/pull/13462#issuecomment-809678631
@rusackas Ephemeral environment spinning up at http://54.188.68.162:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13462: chore: Removes Popover duplication
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13462:
URL: https://github.com/apache/superset/pull/13462#issuecomment-790830643
# [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=h1) Report
> Merging [#13462](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=desc) (d62ed59) into [master](https://codecov.io/gh/apache/superset/commit/9773aba522e957ed9423045ca153219638a85d2f?el=desc) (9773aba) will **increase** coverage by `0.71%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head d62ed59 differs from pull request most recent head f56c213. Consider uploading reports for the commit f56c213 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13462 +/- ##
==========================================
+ Coverage 75.91% 76.63% +0.71%
==========================================
Files 933 932 -1
Lines 47185 47183 -2
Branches 5872 5858 -14
==========================================
+ Hits 35821 36158 +337
+ Misses 11191 10866 -325
+ Partials 173 159 -14
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.29% <ø> (+6.27%)` | :arrow_up: |
| javascript | `63.53% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `42.85% <ø> (-37.15%)` | :arrow_down: |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3cG9ydENvbnRyb2wuanN4) | `82.60% <ø> (ø)` | |
| [superset-frontend/src/components/Popover/index.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3Zlci9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `67.30% <100.00%> (+9.61%)` | :arrow_up: |
| [...ilters/FilterBar/CascadeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `83.09% <100.00%> (+19.71%)` | :arrow_up: |
| ... and [101 more](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=footer). Last update [9773aba...f56c213](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13462: chore: Removes Popover duplication
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13462:
URL: https://github.com/apache/superset/pull/13462#issuecomment-790830643
# [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=h1) Report
> Merging [#13462](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=desc) (d62ed59) into [master](https://codecov.io/gh/apache/superset/commit/9773aba522e957ed9423045ca153219638a85d2f?el=desc) (9773aba) will **increase** coverage by `1.55%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head d62ed59 differs from pull request most recent head f56c213. Consider uploading reports for the commit f56c213 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13462 +/- ##
==========================================
+ Coverage 75.91% 77.47% +1.55%
==========================================
Files 933 932 -1
Lines 47185 47183 -2
Branches 5872 5858 -14
==========================================
+ Hits 35821 36554 +733
+ Misses 11191 10487 -704
+ Partials 173 142 -31
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.25% <ø> (+10.23%)` | :arrow_up: |
| javascript | `63.53% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (+2.85%)` | :arrow_up: |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3cG9ydENvbnRyb2wuanN4) | `82.60% <ø> (ø)` | |
| [superset-frontend/src/components/Popover/index.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3Zlci9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `67.30% <100.00%> (+9.61%)` | :arrow_up: |
| [...ilters/FilterBar/CascadeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `83.09% <100.00%> (+19.71%)` | :arrow_up: |
| ... and [106 more](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=footer). Last update [9773aba...f56c213](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13462: chore: Removes Popover duplication
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13462:
URL: https://github.com/apache/superset/pull/13462#issuecomment-790830643
# [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=h1) Report
> Merging [#13462](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=desc) (92f4cb1) into [master](https://codecov.io/gh/apache/superset/commit/6026e7d47ac78b738b7f1fc56fbaa1795be8dfd5?el=desc) (6026e7d) will **increase** coverage by `0.70%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13462 +/- ##
==========================================
+ Coverage 72.74% 73.45% +0.70%
==========================================
Files 906 609 -297
Lines 45654 21330 -24324
Branches 5516 5531 +15
==========================================
- Hits 33212 15668 -17544
+ Misses 12232 5535 -6697
+ Partials 210 127 -83
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.93% <ø> (?)` | |
| hive | `?` | |
| javascript | `63.40% <100.00%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (+74.28%)` | :arrow_up: |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3cG9ydENvbnRyb2wuanN4) | `82.60% <ø> (ø)` | |
| [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `62.22% <100.00%> (+6.66%)` | :arrow_up: |
| [...ponents/nativeFilters/FilterBar/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `97.10% <100.00%> (+34.78%)` | :arrow_up: |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=footer). Last update [6026e7d...151d6e5](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13462: chore: Removes Popover duplication
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13462:
URL: https://github.com/apache/superset/pull/13462#issuecomment-790830643
# [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=h1) Report
> Merging [#13462](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=desc) (d62ed59) into [master](https://codecov.io/gh/apache/superset/commit/9773aba522e957ed9423045ca153219638a85d2f?el=desc) (9773aba) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head d62ed59 differs from pull request most recent head f56c213. Consider uploading reports for the commit f56c213 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13462 +/- ##
==========================================
- Coverage 75.91% 75.91% -0.01%
==========================================
Files 933 933
Lines 47185 47183 -2
Branches 5872 5859 -13
==========================================
- Hits 35821 35819 -2
Misses 11191 11191
Partials 173 173
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.53% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `80.00% <ø> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3cG9ydENvbnRyb2wuanN4) | `82.60% <ø> (ø)` | |
| [superset-frontend/src/components/Popover/index.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3Zlci9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `57.69% <100.00%> (ø)` | |
| [...ilters/FilterBar/CascadeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `63.38% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=footer). Last update [9773aba...f56c213](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #13462: chore: Removes Popover duplication
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #13462:
URL: https://github.com/apache/superset/pull/13462#issuecomment-809581145
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #13462: chore: Removes Popover duplication
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #13462:
URL: https://github.com/apache/superset/pull/13462#issuecomment-790880065
> It seems like `import Popover from 'src/components/Popover';` just loads a wrapper which effectively aliases `import { Popover } from 'src/common/components';` - should we just point directly to the latter, and remove `src/components/Popover`? It seems like the only reason to keep the wrapper would be if we intend to enhance or style the "stock" popover.
Great question @rusackas! `src/common/components` will be deleted when we migrate all to `src/components`. The import in `src/components/Popover` is wrong, it should be `from antd`. I'll fix it!
Later we'll create and index in src/components and export all with named exports. Then we could delete `src/components/Popover` if there's no customization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13462: chore: Removes Popover duplication
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13462:
URL: https://github.com/apache/superset/pull/13462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13462: chore: Removes Popover duplication
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13462:
URL: https://github.com/apache/superset/pull/13462#issuecomment-790830643
# [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=h1) Report
> Merging [#13462](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=desc) (8724512) into [master](https://codecov.io/gh/apache/superset/commit/9773aba522e957ed9423045ca153219638a85d2f?el=desc) (9773aba) will **decrease** coverage by `2.97%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 8724512 differs from pull request most recent head f56c213. Consider uploading reports for the commit f56c213 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13462 +/- ##
==========================================
- Coverage 75.91% 72.94% -2.98%
==========================================
Files 933 611 -322
Lines 47185 21500 -25685
Branches 5872 5587 -285
==========================================
- Hits 35821 15683 -20138
+ Misses 11191 5685 -5506
+ Partials 173 132 -41
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.50% <ø> (+11.48%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.91% <100.00%> (-0.63%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (+2.85%)` | :arrow_up: |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3cG9ydENvbnRyb2wuanN4) | `82.60% <ø> (ø)` | |
| [superset-frontend/src/components/Popover/index.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3Zlci9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `62.22% <100.00%> (+4.52%)` | :arrow_up: |
| ... and [596 more](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=footer). Last update [9773aba...f56c213](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13462: chore: Removes Popover duplication
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13462:
URL: https://github.com/apache/superset/pull/13462#issuecomment-790830643
# [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=h1) Report
> Merging [#13462](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=desc) (8724512) into [master](https://codecov.io/gh/apache/superset/commit/49eeab6f55e9e1f35b8a46e2906fe42d1cdf1f72?el=desc) (49eeab6) will **decrease** coverage by `3.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13462 +/- ##
==========================================
- Coverage 76.05% 72.94% -3.11%
==========================================
Files 913 611 -302
Lines 46046 21500 -24546
Branches 5505 5587 +82
==========================================
- Hits 35018 15683 -19335
+ Misses 10865 5685 -5180
+ Partials 163 132 -31
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.50% <ø> (+6.11%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.91% <100.00%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (+40.00%)` | :arrow_up: |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3cG9ydENvbnRyb2wuanN4) | `82.60% <ø> (ø)` | |
| [superset-frontend/src/components/Popover/index.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3Zlci9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `62.22% <100.00%> (ø)` | |
| ... and [359 more](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=footer). Last update [49eeab6...8cb0355](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13462: chore: Removes Popover duplication
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13462:
URL: https://github.com/apache/superset/pull/13462#issuecomment-810720152
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13462: chore: Removes Popover duplication
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13462:
URL: https://github.com/apache/superset/pull/13462#issuecomment-790830643
# [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=h1) Report
> Merging [#13462](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=desc) (92f4cb1) into [master](https://codecov.io/gh/apache/superset/commit/49eeab6f55e9e1f35b8a46e2906fe42d1cdf1f72?el=desc) (49eeab6) will **decrease** coverage by `2.59%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13462 +/- ##
==========================================
- Coverage 76.05% 73.45% -2.60%
==========================================
Files 913 609 -304
Lines 46046 21330 -24716
Branches 5505 5531 +26
==========================================
- Hits 35018 15668 -19350
+ Misses 10865 5535 -5330
+ Partials 163 127 -36
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.93% <ø> (+6.54%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.40% <100.00%> (+0.49%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (+40.00%)` | :arrow_up: |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3cG9ydENvbnRyb2wuanN4) | `82.60% <ø> (ø)` | |
| [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `62.22% <100.00%> (ø)` | |
| [...ponents/nativeFilters/FilterBar/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `97.10% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [427 more](https://codecov.io/gh/apache/superset/pull/13462/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=footer). Last update [49eeab6...8cb0355](https://codecov.io/gh/apache/superset/pull/13462?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org