You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Aaron Morton (JIRA)" <ji...@apache.org> on 2011/08/19 05:08:29 UTC
[jira] [Created] (HADOOP-7556) TaskLogAppender does not check if
closed before flushing
TaskLogAppender does not check if closed before flushing
--------------------------------------------------------
Key: HADOOP-7556
URL: https://issues.apache.org/jira/browse/HADOOP-7556
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 0.20.203.0
Reporter: Aaron Morton
Priority: Minor
For background see http://groups.google.com/group/brisk-users/browse_thread/thread/3a18f4679673bea8
http://mail-archives.apache.org/mod_mbox/hadoop-common-user/201108.mbox/%3C4E370C97-1541-4FDA-8456-1067DDDC4D77@thelastpickle.com%3E
Cassandra is using a log4j PropertyConfigurator which is closing all existing appenders. After a task has completed the TaskLogAppender.flush() is called and it tries to flush without checking if the writer has been closed. I'll upload a patch to check if the writer is closed, and log and silently fail if it is.
The real problem is the log4j config collision, we're looking to different log4j LoggerRepositories for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7556) TaskLogAppender does not check if
closed before flushing
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087512#comment-13087512 ]
Hadoop QA commented on HADOOP-7556:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490914/HADDOP-7556.diff
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/53//console
This message is automatically generated.
> TaskLogAppender does not check if closed before flushing
> --------------------------------------------------------
>
> Key: HADOOP-7556
> URL: https://issues.apache.org/jira/browse/HADOOP-7556
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.203.0
> Reporter: Aaron Morton
> Priority: Minor
> Attachments: HADDOP-7556.diff
>
>
> For background see http://groups.google.com/group/brisk-users/browse_thread/thread/3a18f4679673bea8
> http://mail-archives.apache.org/mod_mbox/hadoop-common-user/201108.mbox/%3C4E370C97-1541-4FDA-8456-1067DDDC4D77@thelastpickle.com%3E
> Cassandra is using a log4j PropertyConfigurator which is closing all existing appenders. After a task has completed the TaskLogAppender.flush() is called and it tries to flush without checking if the writer has been closed. I'll upload a patch to check if the writer is closed, and log and silently fail if it is.
> The real problem is the log4j config collision, we're looking to different log4j LoggerRepositories for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7556) TaskLogAppender does not check if
closed before flushing
Posted by "Aaron Morton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Morton updated HADOOP-7556:
---------------------------------
Attachment: HADDOP-7556.diff
Patch to check if the TaskLogAppender is closed before flushing.
> TaskLogAppender does not check if closed before flushing
> --------------------------------------------------------
>
> Key: HADOOP-7556
> URL: https://issues.apache.org/jira/browse/HADOOP-7556
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.203.0
> Reporter: Aaron Morton
> Priority: Minor
> Attachments: HADDOP-7556.diff
>
>
> For background see http://groups.google.com/group/brisk-users/browse_thread/thread/3a18f4679673bea8
> http://mail-archives.apache.org/mod_mbox/hadoop-common-user/201108.mbox/%3C4E370C97-1541-4FDA-8456-1067DDDC4D77@thelastpickle.com%3E
> Cassandra is using a log4j PropertyConfigurator which is closing all existing appenders. After a task has completed the TaskLogAppender.flush() is called and it tries to flush without checking if the writer has been closed. I'll upload a patch to check if the writer is closed, and log and silently fail if it is.
> The real problem is the log4j config collision, we're looking to different log4j LoggerRepositories for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7556) TaskLogAppender does not check if
closed before flushing
Posted by "Aaron Morton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087522#comment-13087522 ]
Aaron Morton commented on HADOOP-7556:
--------------------------------------
I see my patch failed. Could some one tell me the correct branch (was using branch-0.20) and I will rebase.
> TaskLogAppender does not check if closed before flushing
> --------------------------------------------------------
>
> Key: HADOOP-7556
> URL: https://issues.apache.org/jira/browse/HADOOP-7556
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.203.0
> Reporter: Aaron Morton
> Priority: Minor
> Attachments: HADDOP-7556.diff
>
>
> For background see http://groups.google.com/group/brisk-users/browse_thread/thread/3a18f4679673bea8
> http://mail-archives.apache.org/mod_mbox/hadoop-common-user/201108.mbox/%3C4E370C97-1541-4FDA-8456-1067DDDC4D77@thelastpickle.com%3E
> Cassandra is using a log4j PropertyConfigurator which is closing all existing appenders. After a task has completed the TaskLogAppender.flush() is called and it tries to flush without checking if the writer has been closed. I'll upload a patch to check if the writer is closed, and log and silently fail if it is.
> The real problem is the log4j config collision, we're looking to different log4j LoggerRepositories for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7556) TaskLogAppender does not check if
closed before flushing
Posted by "Steve Loughran (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211101#comment-13211101 ]
Steve Loughran commented on HADOOP-7556:
----------------------------------------
There's a couple of places the patch should go.
* if you want it in trunk & 0.23, then a patch against trunk will usually work in both
* for the 1.x branch, it'll need to be against hadoop/common/branches/branch-1/
> TaskLogAppender does not check if closed before flushing
> --------------------------------------------------------
>
> Key: HADOOP-7556
> URL: https://issues.apache.org/jira/browse/HADOOP-7556
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.203.0
> Reporter: Aaron Morton
> Priority: Minor
> Attachments: HADDOP-7556.diff
>
>
> For background see http://groups.google.com/group/brisk-users/browse_thread/thread/3a18f4679673bea8
> http://mail-archives.apache.org/mod_mbox/hadoop-common-user/201108.mbox/%3C4E370C97-1541-4FDA-8456-1067DDDC4D77@thelastpickle.com%3E
> Cassandra is using a log4j PropertyConfigurator which is closing all existing appenders. After a task has completed the TaskLogAppender.flush() is called and it tries to flush without checking if the writer has been closed. I'll upload a patch to check if the writer is closed, and log and silently fail if it is.
> The real problem is the log4j config collision, we're looking to different log4j LoggerRepositories for that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7556) TaskLogAppender does not check if
closed before flushing
Posted by "Aaron Morton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Morton updated HADOOP-7556:
---------------------------------
Status: Patch Available (was: Open)
> TaskLogAppender does not check if closed before flushing
> --------------------------------------------------------
>
> Key: HADOOP-7556
> URL: https://issues.apache.org/jira/browse/HADOOP-7556
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.203.0
> Reporter: Aaron Morton
> Priority: Minor
> Attachments: HADDOP-7556.diff
>
>
> For background see http://groups.google.com/group/brisk-users/browse_thread/thread/3a18f4679673bea8
> http://mail-archives.apache.org/mod_mbox/hadoop-common-user/201108.mbox/%3C4E370C97-1541-4FDA-8456-1067DDDC4D77@thelastpickle.com%3E
> Cassandra is using a log4j PropertyConfigurator which is closing all existing appenders. After a task has completed the TaskLogAppender.flush() is called and it tries to flush without checking if the writer has been closed. I'll upload a patch to check if the writer is closed, and log and silently fail if it is.
> The real problem is the log4j config collision, we're looking to different log4j LoggerRepositories for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira