[GitHub] sijie commented on a change in pull request #1398: ISSUE #1339: Cleanup the directories created by DbLedgerStorageTest

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1398: ISSUE #1339: Cleanup the directories created by DbLedgerStorageTest
URL: https://github.com/apache/bookkeeper/pull/1398#discussion_r187247855
 
 

 ##########
 File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageTest.java
 ##########
 @@ -241,16 +242,20 @@ public void testBookieCompaction() throws Exception {
     @Test
     public void doubleDirectory() throws Exception {
         int gcWaitTime = 1000;
+        File firstDir = new File("dir1");
 
 Review comment:
   nit: a better approach would be create the subdir under the tmpDir initialized in this test suite.
   
   ```
   File firstDir = new File(tmpDir, "dir1");
   File secondDir = new File(tmpDir, "dir2");
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services