You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/12 07:40:42 UTC

[GitHub] [incubator-pinot] codecov-io commented on issue #4432: #4401 Reuse a ThreadLocal byte[] when reading String elements from the variable length value reader.

codecov-io commented on issue #4432: #4401 Reuse a ThreadLocal byte[] when reading String elements from the variable length value reader.
URL: https://github.com/apache/incubator-pinot/pull/4432#issuecomment-510784132
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4432?src=pr&el=h1) Report
   > Merging [#4432](https://codecov.io/gh/apache/incubator-pinot/pull/4432?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/52f9b085dab355ae70a0b262de7e3c3c5500df09?src=pr&el=desc) will **increase** coverage by `20.9%`.
   > The diff coverage is `84.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4432/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4432?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4432      +/-   ##
   ============================================
   + Coverage     44.37%   65.27%   +20.9%     
   - Complexity        0       20      +20     
   ============================================
     Files          1075     1075              
     Lines         55837    55845       +8     
     Branches       7965     7965              
   ============================================
   + Hits          24775    36451   +11676     
   + Misses        28939    16787   -12152     
   - Partials       2123     2607     +484
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...java/org/apache/pinot/common/utils/StringUtil.java](https://codecov.io/gh/apache/incubator-pinot/pull/4432/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvU3RyaW5nVXRpbC5qYXZh) | `72.22% <100%> (+22.22%)` | `0 <0> (ø)` | :arrow_down: |
   | [.../core/io/util/VarLengthBytesValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4432/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby91dGlsL1Zhckxlbmd0aEJ5dGVzVmFsdWVSZWFkZXJXcml0ZXIuamF2YQ==) | `85.71% <83.33%> (+71.19%)` | `0 <0> (ø)` | :arrow_down: |
   | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4432/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `19.17% <0%> (-56.17%)` | `0% <0%> (ø)` | |
   | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4432/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-50%)` | `0% <0%> (ø)` | |
   | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/4432/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `32.05% <0%> (-48.72%)` | `0% <0%> (ø)` | |
   | [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4432/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=) | `42.62% <0%> (-26.23%)` | `0% <0%> (ø)` | |
   | [...egation/function/customobject/MinMaxRangePair.java](https://codecov.io/gh/apache/incubator-pinot/pull/4432/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9jdXN0b21vYmplY3QvTWluTWF4UmFuZ2VQYWlyLmphdmE=) | `75.86% <0%> (-24.14%)` | `0% <0%> (ø)` | |
   | [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4432/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `69.56% <0%> (-13.05%)` | `0% <0%> (ø)` | |
   | [...pinot/core/operator/docidsets/OrBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/4432/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvT3JCbG9ja0RvY0lkU2V0LmphdmE=) | `88.67% <0%> (-9.44%)` | `0% <0%> (ø)` | |
   | [...he/pinot/controller/util/SegmentIntervalUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4432/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL1NlZ21lbnRJbnRlcnZhbFV0aWxzLmphdmE=) | `0% <0%> (-7.15%)` | `0% <0%> (ø)` | |
   | ... and [562 more](https://codecov.io/gh/apache/incubator-pinot/pull/4432/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4432?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4432?src=pr&el=footer). Last update [52f9b08...a512ec3](https://codecov.io/gh/apache/incubator-pinot/pull/4432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org