[jira] Commented: (SOLR-135) Restructure / Refactor codebase for shared libraries

["Ryan McKinley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469711 ] 

Ryan McKinley commented on SOLR-135:
------------------------------------

A first start for this would be to move:
  /solr/src/java/org/apache/solr/util/
to:
 /solr/src/common/org/apache/solr/util/

(or some other name, "shared"?)

It would also be nice to move:
 AbstractSolrTestCase.java, TestHarness.java, and o.a.s.util.test to:
 \solr\src\test\org\apache\solr\util

As a first pass, SolrParams.java and ContentStream.java should be moved to:
  /solr/src/common/org/apache/solr/request/

Longer term, the logic and constants should be seperated from SolrParams.java

I *think* a quick version of this could be done that would not affect any existing code, just the build.xml file.  

- - - - - - 

should o.a.s.tst be moved to \solr\src\test\org\apache\solr\tst?

I can't quite figure out what "tst" does.



> Restructure / Refactor codebase for shared libraries
> ----------------------------------------------------
>
>                 Key: SOLR-135
>                 URL: https://issues.apache.org/jira/browse/SOLR-135
>             Project: Solr
>          Issue Type: Wish
>            Reporter: Ryan McKinley
>            Priority: Minor
>
> For SOLR-20 and other java projects, it would be nice to have common code share a codebase that does not require lucene or junit to compile.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Commented: (SOLR-135) Restructure / Refactor codebase for shared libraries

[Chris Hostetter <ho...@fucit.org>]

: It would also be nice to move:
:  AbstractSolrTestCase.java, TestHarness.java, and o.a.s.util.test to:
:  \solr\src\test\org\apache\solr\util

FYI: AbstractSolrTestCase and TestHarness are in the src/java tree instead
of the src/test tree so that they get included in the solr.jar and people
using that jar to write plugins have access to them for writting tests.

o.a.s.util.test only contains TestNumberUtils.java which i don't even
remember ... by the looks of it it's something yonik wrote back in the
before i convinced him that junit was useful :) ... we should convert it
to a real TestCase.

: should o.a.s.tst be moved to \solr\src\test\org\apache\solr\tst?
:
: I can't quite figure out what "tst" does.

that whole directory should probably be purged.




-Hoss