[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #559: Nxstyle

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #559: Nxstyle
URL: https://github.com/apache/incubator-nuttx/pull/559#discussion_r392193665
 
 

 ##########
 File path: tools/nxstyle.c
 ##########
 @@ -967,8 +968,8 @@ int main(int argc, char **argv, char **envp)
 
                   rhcomment = -1;
 
-                  if (ncomment > 0 && (!strncmp(&line[ii], "if", 2)
-                      || !strncmp(&line[ii], "el", 2)))
+                  if (ncomment > 0 && (strncmp(&line[ii], "if", 2) == 0
+                      || strncmp(&line[ii], "el", 2) == 0))
 
 Review comment:
   In all other places in nxstyle.c, the conditional is broken with the || at the end of the preceding line, not at the beginning of the following line, I don't think this is addressed by the coding standard, but it would be nice to be consistent within the documents.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services