You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/04/30 05:51:44 UTC
Re: Review Request 20277: Introduced 'Libprocess-From' to identify a
libprocess "message".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20277/
-----------------------------------------------------------
(Updated April 30, 2014, 3:51 a.m.)
Review request for mesos, Ben Mahler, Jie Yu, Kevin Sweeney, and Brian Wickman.
Changes
-------
s/libprocess-from/Libprocess-From/
Summary (updated)
-----------------
Introduced 'Libprocess-From' to identify a libprocess "message".
Repository: mesos-git
Description
-------
Enables using the 'libprocess-from' header as an alternative to 'User-Agent'.
Diffs (updated)
-----
3rdparty/libprocess/src/encoder.hpp 7f4593b808b2b14e9b178391d3923782e5428c64
3rdparty/libprocess/src/process.cpp 26c16cf58c31102dc61b5844b3e4d75e5bc2764e
3rdparty/libprocess/src/tests/process_tests.cpp 745c3ada5f55722aed4adb4d0b1fcb16e4cb8e9b
Diff: https://reviews.apache.org/r/20277/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 20277: Introduced 'Libprocess-From' to identify a
libprocess "message".
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20277/#review41806
-----------------------------------------------------------
Bad patch!
Reviews applied: [20277]
Failed command: git apply --index 20277.patch
Error:
error: patch failed: 3rdparty/libprocess/src/tests/process_tests.cpp:1431
error: 3rdparty/libprocess/src/tests/process_tests.cpp: patch does not apply
- Mesos ReviewBot
On April 30, 2014, 3:51 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20277/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 3:51 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Kevin Sweeney, and Brian Wickman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enables using the 'libprocess-from' header as an alternative to 'User-Agent'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/encoder.hpp 7f4593b808b2b14e9b178391d3923782e5428c64
> 3rdparty/libprocess/src/process.cpp 26c16cf58c31102dc61b5844b3e4d75e5bc2764e
> 3rdparty/libprocess/src/tests/process_tests.cpp 745c3ada5f55722aed4adb4d0b1fcb16e4cb8e9b
>
> Diff: https://reviews.apache.org/r/20277/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 20277: Introduced 'Libprocess-From' to identify a
libprocess "message".
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On April 30, 2014, 5:50 a.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/process.cpp, line 834
> > <https://reviews.apache.org/r/20277/diff/3/?file=571362#file571362line834>
> >
> > Do we need to trim the header string?
It certainly can't hurt.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20277/#review41805
-----------------------------------------------------------
On April 30, 2014, 3:51 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20277/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 3:51 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Kevin Sweeney, and Brian Wickman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enables using the 'libprocess-from' header as an alternative to 'User-Agent'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/encoder.hpp 7f4593b808b2b14e9b178391d3923782e5428c64
> 3rdparty/libprocess/src/process.cpp 26c16cf58c31102dc61b5844b3e4d75e5bc2764e
> 3rdparty/libprocess/src/tests/process_tests.cpp 745c3ada5f55722aed4adb4d0b1fcb16e4cb8e9b
>
> Diff: https://reviews.apache.org/r/20277/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 20277: Introduced 'Libprocess-From' to identify a
libprocess "message".
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20277/#review41805
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/encoder.hpp
<https://reviews.apache.org/r/20277/#comment75432>
Maybe a comment as to why we do this check?
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/20277/#comment75431>
Do we need to trim the header string?
- Ben Mahler
On April 30, 2014, 3:51 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20277/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 3:51 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Kevin Sweeney, and Brian Wickman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enables using the 'libprocess-from' header as an alternative to 'User-Agent'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/encoder.hpp 7f4593b808b2b14e9b178391d3923782e5428c64
> 3rdparty/libprocess/src/process.cpp 26c16cf58c31102dc61b5844b3e4d75e5bc2764e
> 3rdparty/libprocess/src/tests/process_tests.cpp 745c3ada5f55722aed4adb4d0b1fcb16e4cb8e9b
>
> Diff: https://reviews.apache.org/r/20277/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>