[GitHub] [tvm] leandron commented on pull request #12435: [TIR] Expose Misc TIR operations to python

[GitBox <gi...@apache.org>]

leandron commented on PR #12435:
URL: https://github.com/apache/tvm/pull/12435#issuecomment-1214712645

   > 1. These operations are widely uesd in current unittest sets with `T.*` currently. And the current parser directly generates `tir::Call` for these operations, refer to [here](https://github.com/apache/tvm/blob/bb513866ad70fa20eb0c37ca339d330d6a76c747/python/tvm/script/parser.py#L934). However, in the new parser, we will call these operations in `op.py`, as we have just added. The current unittest set will automatically be tests for these newly expoesd `op`s. And these newly added `op`s have passed CI with our new parser as well, which proves their correctness. So we do not add extra unittests this time. Of course, in general cases, we do have to add related unittests for these `op`s.
   
   Please correct me if what I say is wrong, but, my assumption is that all these PRs are making TIR operations that before were accessible in C++, to be available in Python. If so, there should be at least one unittest that make that call in Python, and check whether the expected API call is made.
   
   I understand other test layers for the underneath APIs are already tested for correctness - that's out of scope for this particular PR, but it really would make sense to have a test for the API being exposed here, in Python.
   
   Specifically, we should make sure that basic things are in place, such as the parameters sent are aligned with what the API expects, but more importantly, if the API changes, at least this simple test will break. So I think having these tests are fundamental for us to merge these PRs.
   
   
   > 2. Sure. I will update these commit messages and pay attention to it next time.
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org