[GitHub] [orc] zratkai commented on pull request #1431: ORC-1384: Fix ArrayIndexOutOfBoundsException when reading dictionary stream bigger then dictionary

["zratkai (via GitHub)" <gi...@apache.org>]

zratkai commented on PR #1431:
URL: https://github.com/apache/orc/pull/1431#issuecomment-1461750260

   @dongjoon-hyun 
   
   > Thank you for making a PR, @zratkai .
   > 
   > * Do you happen to know what caused this regression?
   > * Do you think you can add a small unit test which you described in the commets?
   
   1. It is caused by LLAP in Hive, since it reads in 4kB blocks as I described above.
   2. I was thinking about that, but it is not easy for this modification, since it is in a private method, and we don't have any test even for the public method which calls this (org.apache.orc.impl.TreeReaderFactory.StringDictionaryTreeReader#nextVector) . So it would mean I need to create for that as well from scratch. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org