[GitHub] [helix] lei-xia commented on a change in pull request #558: New module hosting Helix Zookeeper access logic

[GitBox <gi...@apache.org>]

lei-xia commented on a change in pull request #558: New module hosting Helix Zookeeper access logic
URL: https://github.com/apache/helix/pull/558#discussion_r349753728
 
 

 ##########
 File path: helix-core/pom.xml
 ##########
 @@ -159,6 +159,10 @@ under the License.
       <artifactId>metrics-core</artifactId>
       <version>3.2.3</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.helix</groupId>
+      <artifactId>helix-zk</artifactId>
 
 Review comment:
   my suggestion is also to not include any helix* keywords in this module, maybe just zookeeper, or zookeeper-client, or zookeeper-api, etc. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org