You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/08 06:11:35 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #37829: [SPARK-40386][PS][SQL] Implement `ddof` in `DataFrame.cov`
zhengruifeng opened a new pull request, #37829:
URL: https://github.com/apache/spark/pull/37829
### What changes were proposed in this pull request?
1, add a dedicated expression for `DataFrame.cov`;
2, add missing parameter `ddof` in `DataFrame.cov`
### Why are the changes needed?
for api coverage
### Does this PR introduce _any_ user-facing change?
yes, API change
### How was this patch tested?
added tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #37829: [SPARK-40386][PS][SQL] Implement `ddof` in `DataFrame.cov`
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #37829:
URL: https://github.com/apache/spark/pull/37829#issuecomment-1244859986
Merged into master, thank you @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #37829: [SPARK-40386][PS][SQL] Implement `ddof` in `DataFrame.cov`
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #37829:
URL: https://github.com/apache/spark/pull/37829#issuecomment-1240612333
cc @itholic @HyukjinKwon @xinrong-meng @Yikun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #37829: [SPARK-40386][PS][SQL] Implement `ddof` in `DataFrame.cov`
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #37829: [SPARK-40386][PS][SQL] Implement `ddof` in `DataFrame.cov`
URL: https://github.com/apache/spark/pull/37829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org