You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/01/31 07:49:54 UTC
[GitHub] dongeforever commented on a change in pull request #521:
[ISSUE#502]Add new feature : pull consumer support sql92 filter.
dongeforever commented on a change in pull request #521: [ISSUE#502]Add new feature : pull consumer support sql92 filter.
URL: https://github.com/apache/rocketmq/pull/521#discussion_r252563044
##########
File path: client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
##########
@@ -1042,6 +1042,19 @@ public int findBrokerVersion(String brokerName, String brokerAddr) {
if (this.brokerVersionTable.get(brokerName).containsKey(brokerAddr)) {
return this.brokerVersionTable.get(brokerName).get(brokerAddr);
}
+ } else {
+ HeartbeatData heartbeatData = prepareHeartbeatData();
+ try {
+ int version = this.mQClientAPIImpl.sendHearbeat(brokerAddr, heartbeatData, 3000);
+ return version;
+ } catch (Exception e) {
Review comment:
Here, every single pull request will send a heartBeat, which brings a heavy load on the broker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services