[jira] [Commented] (ATLAS-583) Rename table should retain traits/tags assigned to columns/storage descriptors

["ATLAS QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ATLAS-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243630#comment-15243630 ] 

ATLAS QA commented on ATLAS-583:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12798997/ATLAS-583.patch
  against master revision daf812a.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

      {color:red}-1 javac{color}.  The applied patch generated 113 javac compiler warnings (more than the master's current 109 warnings).

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    +1 checkstyle.  The patch generated 0 code style errors.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 355 new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
 ./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.TypesJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.AdminJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.MetadataDiscoveryJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.RexsterGraphJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.EntityJerseyResourceIT

Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Javac warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/162//console

This message is automatically generated.

> Rename table should retain traits/tags assigned to columns/storage descriptors
> ------------------------------------------------------------------------------
>
>                 Key: ATLAS-583
>                 URL: https://issues.apache.org/jira/browse/ATLAS-583
>             Project: Atlas
>          Issue Type: Sub-task
>    Affects Versions: 0.7-incubating
>            Reporter: Suma Shivaprasad
>            Assignee: Suma Shivaprasad
>             Fix For: 0.7-incubating
>
>         Attachments: ATLAS-583.patch
>
>
> Currently rename changes the column qualifiedName in the renamed table resulting in the columns getting deleted and therefore the traits attached to these will also get deleted. We need to ensure  they are retained by ensuring columns are renamed first to the new qualified name and then table is renamed in the repository



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)