You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Xavier López (Created JIRA)" <ji...@apache.org> on 2011/11/08 10:54:51 UTC
[jira] [Created] (WICKET-4204) AutoComplete+OnChangeAjaxBehavior
doesn't fire updates on item selection
AutoComplete+OnChangeAjaxBehavior doesn't fire updates on item selection
------------------------------------------------------------------------
Key: WICKET-4204
URL: https://issues.apache.org/jira/browse/WICKET-4204
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.5.2
Reporter: Xavier López
When adding an OnChangeAjaxBehavior to an AutoCompleteTextField, onUpdate() doesn't fire when selecting an item from the autocomplete item list.
It is firing when using an AjaxFormComponentUpdatingBehavior.
wicket-autocomplete.js seems to be using the onchange event handler, which is cleared by Wicket.ChangeHandler.
Maybe obj.onchangeoriginal should be checked in first place in wicket-autocomplete.js
See this related discussion at SO for context: http://stackoverflow.com/q/8047769/851811
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4204)
AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item
selection
Posted by "Xavier López (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier López updated WICKET-4204:
---------------------------------
Summary: AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item selection (was: AutoComplete+OnChangeAjaxBehavior doesn't fire updates on item selection)
> AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item selection
> ---------------------------------------------------------------------------------
>
> Key: WICKET-4204
> URL: https://issues.apache.org/jira/browse/WICKET-4204
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.2
> Reporter: Xavier López
>
> When adding an OnChangeAjaxBehavior to an AutoCompleteTextField, onUpdate() doesn't fire when selecting an item from the autocomplete item list.
> It is firing when using an AjaxFormComponentUpdatingBehavior.
> wicket-autocomplete.js seems to be using the onchange event handler, which is cleared by Wicket.ChangeHandler.
> Maybe obj.onchangeoriginal should be checked in first place in wicket-autocomplete.js
> See this related discussion at SO for context: http://stackoverflow.com/q/8047769/851811
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4204)
AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item
selection
Posted by "Xavier López (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147831#comment-13147831 ]
Xavier López commented on WICKET-4204:
--------------------------------------
I've not tried the patch, but if it is firing "onpaste"/"oninput", wouldn't it make other behaviors that only appended "onchange" (such as new AjaxFormComponentUpdatingBehavior("onchange")) stop working (they were before the patch).
> AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item selection
> ---------------------------------------------------------------------------------
>
> Key: WICKET-4204
> URL: https://issues.apache.org/jira/browse/WICKET-4204
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.2
> Reporter: Xavier López
> Attachments: WICKET-4204.patch
>
>
> When adding an OnChangeAjaxBehavior to an AutoCompleteTextField, onUpdate() doesn't fire when selecting an item from the autocomplete item list.
> It is firing when using an AjaxFormComponentUpdatingBehavior.
> wicket-autocomplete.js seems to be using the onchange event handler, which is cleared by Wicket.ChangeHandler.
> Maybe obj.onchangeoriginal should be checked in first place in wicket-autocomplete.js
> See this related discussion at SO for context: http://stackoverflow.com/q/8047769/851811
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4204)
AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item
selection
Posted by "Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4204.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0
Assignee: Martin Grigorov
I'd say this is fixed in 6.0.
Here Autocomplete component uses the special "inputchanged" (see OnChangeAjaxBehavior) event to work. I added explicitly OnChangeAjaxBehavior to the autocomplete component and it didn't break the functionality.
#onChange() method received just the letter typed by the user, not the selected choice afterwards.
> AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item selection
> ---------------------------------------------------------------------------------
>
> Key: WICKET-4204
> URL: https://issues.apache.org/jira/browse/WICKET-4204
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.2
> Reporter: Xavier López
> Assignee: Martin Grigorov
> Fix For: 6.0.0
>
> Attachments: WICKET-4204.patch
>
>
> When adding an OnChangeAjaxBehavior to an AutoCompleteTextField, onUpdate() doesn't fire when selecting an item from the autocomplete item list.
> It is firing when using an AjaxFormComponentUpdatingBehavior.
> wicket-autocomplete.js seems to be using the onchange event handler, which is cleared by Wicket.ChangeHandler.
> Maybe obj.onchangeoriginal should be checked in first place in wicket-autocomplete.js
> See this related discussion at SO for context: http://stackoverflow.com/q/8047769/851811
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4204)
AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item
selection
Posted by "Andrea Del Bene (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147790#comment-13147790 ]
Andrea Del Bene commented on WICKET-4204:
-----------------------------------------
When an item of the list is selected, the event "onclick" is passed to AutoCompleteTextField's onchange by the click handler defined at line 578 of wicket-autocomplete.js.
A possible solution is to trigger a new event which is not ignored by AutoCompleteTextField. See patch.
> AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item selection
> ---------------------------------------------------------------------------------
>
> Key: WICKET-4204
> URL: https://issues.apache.org/jira/browse/WICKET-4204
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.2
> Reporter: Xavier López
> Attachments: WICKET-4204.patch
>
>
> When adding an OnChangeAjaxBehavior to an AutoCompleteTextField, onUpdate() doesn't fire when selecting an item from the autocomplete item list.
> It is firing when using an AjaxFormComponentUpdatingBehavior.
> wicket-autocomplete.js seems to be using the onchange event handler, which is cleared by Wicket.ChangeHandler.
> Maybe obj.onchangeoriginal should be checked in first place in wicket-autocomplete.js
> See this related discussion at SO for context: http://stackoverflow.com/q/8047769/851811
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4204)
AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item
selection
Posted by "Andrea Del Bene (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148113#comment-13148113 ]
Andrea Del Bene commented on WICKET-4204:
-----------------------------------------
@Martin
I hope so too :)
@Xavier
You are right, but at this point it's not clear to me why AutoCompleteTextField overrides its onchange handler with Wicket.ChangeHandler...
> AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item selection
> ---------------------------------------------------------------------------------
>
> Key: WICKET-4204
> URL: https://issues.apache.org/jira/browse/WICKET-4204
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.2
> Reporter: Xavier López
> Attachments: WICKET-4204.patch
>
>
> When adding an OnChangeAjaxBehavior to an AutoCompleteTextField, onUpdate() doesn't fire when selecting an item from the autocomplete item list.
> It is firing when using an AjaxFormComponentUpdatingBehavior.
> wicket-autocomplete.js seems to be using the onchange event handler, which is cleared by Wicket.ChangeHandler.
> Maybe obj.onchangeoriginal should be checked in first place in wicket-autocomplete.js
> See this related discussion at SO for context: http://stackoverflow.com/q/8047769/851811
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4204)
AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item
selection
Posted by "Andrea Del Bene (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrea Del Bene updated WICKET-4204:
------------------------------------
Attachment: WICKET-4204.patch
> AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item selection
> ---------------------------------------------------------------------------------
>
> Key: WICKET-4204
> URL: https://issues.apache.org/jira/browse/WICKET-4204
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.2
> Reporter: Xavier López
> Attachments: WICKET-4204.patch
>
>
> When adding an OnChangeAjaxBehavior to an AutoCompleteTextField, onUpdate() doesn't fire when selecting an item from the autocomplete item list.
> It is firing when using an AjaxFormComponentUpdatingBehavior.
> wicket-autocomplete.js seems to be using the onchange event handler, which is cleared by Wicket.ChangeHandler.
> Maybe obj.onchangeoriginal should be checked in first place in wicket-autocomplete.js
> See this related discussion at SO for context: http://stackoverflow.com/q/8047769/851811
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4204)
AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item
selection
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147799#comment-13147799 ]
Martin Grigorov commented on WICKET-4204:
-----------------------------------------
I hope all this will be solved cleanly with Wicket.next's use of jQuery.
> AutoCompleteTextField+OnChangeAjaxBehavior doesn't fire updates on item selection
> ---------------------------------------------------------------------------------
>
> Key: WICKET-4204
> URL: https://issues.apache.org/jira/browse/WICKET-4204
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.2
> Reporter: Xavier López
> Attachments: WICKET-4204.patch
>
>
> When adding an OnChangeAjaxBehavior to an AutoCompleteTextField, onUpdate() doesn't fire when selecting an item from the autocomplete item list.
> It is firing when using an AjaxFormComponentUpdatingBehavior.
> wicket-autocomplete.js seems to be using the onchange event handler, which is cleared by Wicket.ChangeHandler.
> Maybe obj.onchangeoriginal should be checked in first place in wicket-autocomplete.js
> See this related discussion at SO for context: http://stackoverflow.com/q/8047769/851811
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira