You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tschaub (via GitHub)" <gi...@apache.org> on 2023/09/24 03:01:18 UTC
[GitHub] [arrow] tschaub opened a new pull request, #37846: GH-37845: [Go][Parquet] Check the number of logical fields instead of physical columns
tschaub opened a new pull request, #37846:
URL: https://github.com/apache/arrow/pull/37846
### Rationale for this change
This makes it so trying to read with a column chunk reader consistently returns an error if the index is outside the bounds of the logical fields (currently it panics in some cases and returns an error in others).
### What changes are included in this PR?
This makes it so the column chunk reader checks the number of logical fields instead of the number of physical columns when checking if an index is out of range.
### Are these changes tested?
The new test will panics without the accompanying code change.
### Are there any user-facing changes?
Applications that used to panic will now have an error to handle instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37846: GH-37845: [Go][Parquet] Check the number of logical fields instead of physical columns
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37846:
URL: https://github.com/apache/arrow/pull/37846#issuecomment-1732463575
:warning: GitHub issue #37845 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #37846: GH-37845: [Go][Parquet] Check the number of logical fields instead of physical columns
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #37846:
URL: https://github.com/apache/arrow/pull/37846#issuecomment-1735726208
Thanks @tschaub !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37846: GH-37845: [Go][Parquet] Check the number of logical fields instead of physical columns
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37846:
URL: https://github.com/apache/arrow/pull/37846#issuecomment-1737629626
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 2895af492236e5dc42ac665406de8648a9aac6db.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17185541204) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #37846: GH-37845: [Go][Parquet] Check the number of logical fields instead of physical columns
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #37846:
URL: https://github.com/apache/arrow/pull/37846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org