[jira] [Commented] (HIVE-13171) Add unit test for hs2 webui

["Aihua Xu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-13171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179182#comment-15179182 ] 

Aihua Xu commented on HIVE-13171:
---------------------------------

[~szehon] It's good to add such unit tests. 

Can you check if the following are needed?

1. SessionManager and HiveConf properties don't need to be public, can be private, right?
2. Do we need to close the session after each test is done?

> Add unit test for hs2 webui
> ---------------------------
>
>                 Key: HIVE-13171
>                 URL: https://issues.apache.org/jira/browse/HIVE-13171
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HiveServer2
>            Reporter: Szehon Ho
>            Assignee: Szehon Ho
>         Attachments: HIVE-13171.2.patch, HIVE-13171.patch
>
>
> With more complex changes going into webui, it is hard to manually verify all the kinds of cases.
> With HIVE-12952, HS2 webui now uses jamon, which should be more unit-testable than plain old jsp.  We can perhaps add unit test for the jamon servlets, or test the new OperationDisplay classes queried by the servlets.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)