You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2012/05/17 02:56:25 UTC

[jira] [Created] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Todd Lipcon created HADOOP-8406:
-----------------------------------

             Summary: CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
                 Key: HADOOP-8406
                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
             Project: Hadoop Common
          Issue Type: Bug
          Components: io
    Affects Versions: 2.0.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon


CompressionCodecFactory defines CODEC_PROVIDERS as:
{code}
  private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
    ServiceLoader.load(CompressionCodec.class);
{code}
but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277543#comment-13277543 ] 

Todd Lipcon commented on HADOOP-8406:
-------------------------------------

Failure is a known bad test. I'll commit this momentarily.
                
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 2.0.1
>
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277571#comment-13277571 ] 

Hudson commented on HADOOP-8406:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #2257 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2257/])
    HADOOP-8406. CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe. Contributed by Todd Lipcon. (Revision 1339476)

     Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339476
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java

                
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 2.0.1
>
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-8406:
--------------------------------

    Status: Patch Available  (was: Open)
    
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277515#comment-13277515 ] 

Hadoop QA commented on HADOOP-8406:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12527752/hadoop-8406.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.fs.viewfs.TestViewFsTrash

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/999//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/999//console

This message is automatically generated.
                
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277739#comment-13277739 ] 

Hudson commented on HADOOP-8406:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1048 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1048/])
    HADOOP-8406. CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe. Contributed by Todd Lipcon. (Revision 1339476)

     Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339476
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java

                
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 2.0.1
>
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277578#comment-13277578 ] 

Hudson commented on HADOOP-8406:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2274 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2274/])
    HADOOP-8406. CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe. Contributed by Todd Lipcon. (Revision 1339476)

     Result = ABORTED
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339476
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java

                
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 2.0.1
>
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277827#comment-13277827 ] 

Hudson commented on HADOOP-8406:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1082 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1082/])
    HADOOP-8406. CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe. Contributed by Todd Lipcon. (Revision 1339476)

     Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339476
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java

                
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 2.0.1
>
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-8406:
--------------------------------

    Attachment: hadoop-8406.txt

Attached patch synchronizes the iteration over this list.

I didn't add a unit test because it would be nearly impossible to write one that failed reliably, since it only affects the very first call after the class has been classloaded.
                
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277565#comment-13277565 ] 

Hudson commented on HADOOP-8406:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2331 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2331/])
    HADOOP-8406. CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe. Contributed by Todd Lipcon. (Revision 1339476)

     Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339476
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java

                
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 2.0.1
>
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277303#comment-13277303 ] 

Todd Lipcon commented on HADOOP-8406:
-------------------------------------

In practice I'm seeing this cause an occasional failure of the first HDFS saveNamespace operation if there are many storage directories configured, because all of the saver threads start and call this function at about the same time.
                
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-8406:
--------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.1
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Committed to branch-2 and trunk.
                
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 2.0.1
>
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277480#comment-13277480 ] 

Eli Collins commented on HADOOP-8406:
-------------------------------------

+1 pending jenkins
                
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (HADOOP-8406) CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy closed HADOOP-8406.
---------------------------------

    
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8406
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.0-alpha
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 2.0.2-alpha
>
>         Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
>   private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
>     ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira