You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/02 06:09:56 UTC

[GitHub] [spark] maropu commented on pull request #30560: [SPARK-33619][SQL] Fix GetMapValueUtil code generation error

maropu commented on pull request #30560:
URL: https://github.com/apache/spark/pull/30560#issuecomment-737014904


   ```
    org.apache.spark.sql.catalyst.expressions.DateExpressionsSuite.Consistent error handling for datetime formatting and parsing functions	16 ms	1
    org.apache.spark.sql.catalyst.expressions.ObjectExpressionsSuite.SPARK-23594 GetExternalRowField should support interpreted execution	49 ms	1
    org.apache.spark.sql.catalyst.expressions.ObjectExpressionsSuite.SPARK-23595 ValidateExternalType should support interpreted execution	0.64 sec	1
    org.apache.spark.sql.catalyst.expressions.RegexpExpressionsSuite.RegexExtract	0.25 sec	1
    org.apache.spark.sql.catalyst.expressions.RegexpExpressionsSuite.RegexExtractAll
   ```
   It seems the five errors? If so, IMO its okay to fix all of them at once. Anyway, nice catch!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org