You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/19 00:30:58 UTC
[GitHub] [airflow] dstandish opened a new pull request #19694: Coalesce `extra` params to None in KubernetesHook
dstandish opened a new pull request #19694:
URL: https://github.com/apache/airflow/pull/19694
When using UI form widgets FAB provides a empty string by default for every param. This turns out to make a difference sometimes. E.g. in this hook, we decide what to do depending on whether the param `is not None` -- and if you've created the connection in the UI, even though you didn't supply a value for this param, it will be `not None`
In this case, I do not think this is a breaking change because e.g. if `kubeconfig_path` is empty string then loading it should fail. This should just allow better functioning of the hook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19694: Coalesce `extra` params to None in KubernetesHook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19694:
URL: https://github.com/apache/airflow/pull/19694#issuecomment-974178623
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish merged pull request #19694: Coalesce `extra` params to None in KubernetesHook
Posted by GitBox <gi...@apache.org>.
dstandish merged pull request #19694:
URL: https://github.com/apache/airflow/pull/19694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #19694: Coalesce `extra` params to None in KubernetesHook
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #19694:
URL: https://github.com/apache/airflow/pull/19694#issuecomment-973646741
> I feel like we should have a test for this too. I can see reversing this being an "optimization" later on.
reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org