[GitHub] spark pull request: [SPARK-14951][SQL] Support subexpression elimi...

[viirya <gi...@git.apache.org>]

Github user viirya commented on the pull request:

    https://github.com/apache/spark/pull/12729#issuecomment-216144354
  
    @davies I did check the generated codes of Skewness and Kurtosis, it actually extracts and eliminates common sub-expressions. I think how much performance difference it achieves should depend on the ratio of the eliminated common sub-expressions to other non-common expressions.
    
    I will run the dataset benchmark too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org