You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/26 22:56:45 UTC

[GitHub] [arrow] yordan-pavlov commented on a change in pull request #9329: [Rust] [Experiment] Replace `Arc` by `ArrayData` in all arrays

yordan-pavlov commented on a change in pull request #9329:
URL: https://github.com/apache/arrow/pull/9329#discussion_r564891587



##########
File path: rust/arrow/src/array/array.rs
##########
@@ -56,11 +55,13 @@ pub trait Array: fmt::Debug + Send + Sync + JsonEqual {
     /// ```
     fn as_any(&self) -> &Any;
 
-    /// Returns a reference-counted pointer to the underlying data of this array.
-    fn data(&self) -> ArrayDataRef;
+    /// Returns a reference to the underlying data of this array.
+    fn data(&self) -> &ArrayData;

Review comment:
       if both `data()` and `data_ref()` return `&ArrayData` may be just `data_ref()` is enough and `data()` should be removed; or possibly change `data()` to return `ArrayData`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org