You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Ganeshsivakumar (via GitHub)" <gi...@apache.org> on 2026/02/02 11:56:37 UTC
[PR] Update java ml module gradle [beam]
Ganeshsivakumar opened a new pull request, #37471:
URL: https://github.com/apache/beam/pull/37471
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java ml module gradle [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37471:
URL: https://github.com/apache/beam/pull/37471#issuecomment-3835144179
Assigning reviewers:
R: @chamikaramj for label java.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java ml module gradle [beam]
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey merged PR #37471:
URL: https://github.com/apache/beam/pull/37471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java ml module gradle [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #37471:
URL: https://github.com/apache/beam/pull/37471#discussion_r2760685783
##########
sdks/java/ml/inference/remote/src/main/java/org/apache/beam/sdk/ml/inference/remote/RetryHandler.java:
##########
@@ -82,13 +77,12 @@ public <T> T execute(RetryableRequest<T> request) throws Exception {
if (backoffMillis == BackOff.STOP) {
LOG.error("Request failed after {} retry attempts.", attempt);
throw new RuntimeException(
- "Request failed after exhausting retries. " +
- "Max retries: " + maxRetries + ", " ,
- lastException);
+ "Request failed after exhausting retries. " + "Max retries: " + maxRetries + ", ",
+ lastException);
}
attempt++;
- LOG.warn("Retry request attempt {} failed with: {}. Retrying in {} ms", attempt, e.getMessage(), backoffMillis);
+ LOG.warn("Retry request attempt {} failed. Retrying in {} ms", attempt, backoffMillis, e);
Review Comment:
While logging the full exception is a great improvement for debugging, the log message itself has lost some useful context by removing the exception message. You can include both the message for quick scanning and the full stack trace for deep dives.
```suggestion
LOG.warn("Retry request attempt {} failed with: {}. Retrying in {} ms", attempt, e.getMessage(), backoffMillis, e);
```
##########
sdks/java/ml/inference/openai/src/test/java/org/apache/beam/sdk/ml/inference/openai/OpenAIModelHandlerIT.java:
##########
@@ -252,33 +292,40 @@ public void testWithDifferentModel() {
// Test with a different model
String input = "Explain quantum computing in one sentence.";
- PCollection<OpenAIModelInput> inputs = pipeline
- .apply("CreateInput", Create.of(input))
- .apply("MapToInput", MapElements
- .into(TypeDescriptor.of(OpenAIModelInput.class))
- .via(OpenAIModelInput::create));
-
- PCollection<Iterable<PredictionResult<OpenAIModelInput, OpenAIModelResponse>>> results = inputs
- .apply("DifferentModelInference",
- RemoteInference.<OpenAIModelInput, OpenAIModelResponse>invoke()
- .handler(OpenAIModelHandler.class)
- .withParameters(OpenAIModelParameters.builder()
- .apiKey(apiKey)
- .modelName("gpt-5")
- .instructionPrompt("Respond concisely")
- .build()));
-
- PAssert.that(results).satisfies(batches -> {
- for (Iterable<PredictionResult<OpenAIModelInput, OpenAIModelResponse>> batch : batches) {
- for (PredictionResult<OpenAIModelInput, OpenAIModelResponse> result : batch) {
- assertNotNull("Output should not be null",
- result.getOutput().getModelResponse());
- assertFalse("Output should not be empty",
- result.getOutput().getModelResponse().trim().isEmpty());
- }
- }
- return null;
- });
+ PCollection<OpenAIModelInput> inputs =
+ pipeline
+ .apply("CreateInput", Create.of(input))
+ .apply(
+ "MapToInput",
+ MapElements.into(TypeDescriptor.of(OpenAIModelInput.class))
+ .via(OpenAIModelInput::create));
+
+ PCollection<Iterable<PredictionResult<OpenAIModelInput, OpenAIModelResponse>>> results =
+ inputs.apply(
+ "DifferentModelInference",
+ RemoteInference.<OpenAIModelInput, OpenAIModelResponse>invoke()
+ .handler(OpenAIModelHandler.class)
+ .withParameters(
+ OpenAIModelParameters.builder()
+ .apiKey(apiKey)
+ .modelName("gpt-5")
Review Comment:
The `gpt-5` model does not exist, which will cause this test to fail with an API error. However, the test asserts a successful outcome. To fix this, please use a valid and available OpenAI model. For example, you could use `gpt-4-turbo` if you want to test a different model from the default `gpt-4o-mini`.
```suggestion
.modelName("gpt-4-turbo")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java ml module gradle [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #37471:
URL: https://github.com/apache/beam/pull/37471#issuecomment-3834693236
## Summary of Changes
Hello @Ganeshsivakumar, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on standardizing and refining the build configurations and code quality for the Java ML inference modules, specifically for OpenAI integration and the remote inference framework. It transitions to a more declarative Gradle setup for Java projects, enhances code readability through reformatting, and improves type safety and documentation, contributing to a more maintainable and robust codebase.
### Highlights
* **Gradle Build Configuration Updates**: The Gradle build files for the `openai` and `remote` ML inference modules have been updated to use `applyJavaNature` for consistent module naming and Java 11 requirement. This replaces the direct `id 'java'` and `id 'java-library'` plugin declarations.
* **Module Metadata and Dependencies**: New `ext.summary` properties have been added to the Gradle files for both `openai` and `remote` modules, providing brief descriptions. Integration testing dependencies and Java performance testing are now explicitly enabled for the `openai` module, and an unnecessary `slf4j_simple` test runtime dependency was removed from the `remote` module.
* **Code Formatting and Javadoc Improvements**: Numerous Java source files across both `openai` and `remote` packages have undergone minor reformatting, including adjustments to whitespace, line breaks, and javadoc comments to improve readability and consistency. This includes correcting quotation marks in license headers.
* **Nullness Annotations and Type Specificity**: The `@SuppressWarnings("nullness")` annotation has been added to `OpenAIModelHandler` and `OpenAIModelParameters` classes. Additionally, the `handler()` method in `RemoteInference.Invoke` now uses more specific type parameters for better type safety.
* **New Package Information Files**: New `package-info.java` files have been added to both `org.apache.beam.sdk.ml.inference.openai` and `org.apache.beam.sdk.ml.inference.remote` packages, providing package-level documentation.
* **Gradle Settings File Correction**: The `settings.gradle.kts` file was updated to correct the module include paths for `sdks:java:ml:inference:remote` and `sdks:java:ml:inference:openai`, ensuring they are properly recognized as subprojects.
🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java ml module gradle [beam]
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #37471:
URL: https://github.com/apache/beam/pull/37471#issuecomment-3843254106
@gemini-code-assist review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java ml module gradle [beam]
Posted by "Ganeshsivakumar (via GitHub)" <gi...@apache.org>.
Ganeshsivakumar commented on code in PR #37471:
URL: https://github.com/apache/beam/pull/37471#discussion_r2762577937
##########
sdks/java/ml/inference/remote/src/main/java/org/apache/beam/sdk/ml/inference/remote/RetryHandler.java:
##########
@@ -82,13 +77,12 @@ public <T> T execute(RetryableRequest<T> request) throws Exception {
if (backoffMillis == BackOff.STOP) {
LOG.error("Request failed after {} retry attempts.", attempt);
throw new RuntimeException(
- "Request failed after exhausting retries. " +
- "Max retries: " + maxRetries + ", " ,
- lastException);
+ "Request failed after exhausting retries. " + "Max retries: " + maxRetries + ", ",
+ lastException);
}
attempt++;
- LOG.warn("Retry request attempt {} failed with: {}. Retrying in {} ms", attempt, e.getMessage(), backoffMillis);
+ LOG.warn("Retry request attempt {} failed. Retrying in {} ms", attempt, backoffMillis, e);
Review Comment:
This triggers lint error since passing exception is sufficient
```
[Slf4jDoNotLogMessageOfExceptionExplicitly] Do not log message returned from Throwable#getMessage and Throwable#getLocalizedMessage. It is enough to provide throwable instance as the last argument, then binding will log its message.
LOG.warn(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update java ml module gradle [beam]
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on code in PR #37471:
URL: https://github.com/apache/beam/pull/37471#discussion_r2760697623
##########
sdks/java/ml/inference/openai/src/test/java/org/apache/beam/sdk/ml/inference/openai/OpenAIModelHandlerIT.java:
##########
@@ -252,33 +292,40 @@ public void testWithDifferentModel() {
// Test with a different model
String input = "Explain quantum computing in one sentence.";
- PCollection<OpenAIModelInput> inputs = pipeline
- .apply("CreateInput", Create.of(input))
- .apply("MapToInput", MapElements
- .into(TypeDescriptor.of(OpenAIModelInput.class))
- .via(OpenAIModelInput::create));
-
- PCollection<Iterable<PredictionResult<OpenAIModelInput, OpenAIModelResponse>>> results = inputs
- .apply("DifferentModelInference",
- RemoteInference.<OpenAIModelInput, OpenAIModelResponse>invoke()
- .handler(OpenAIModelHandler.class)
- .withParameters(OpenAIModelParameters.builder()
- .apiKey(apiKey)
- .modelName("gpt-5")
- .instructionPrompt("Respond concisely")
- .build()));
-
- PAssert.that(results).satisfies(batches -> {
- for (Iterable<PredictionResult<OpenAIModelInput, OpenAIModelResponse>> batch : batches) {
- for (PredictionResult<OpenAIModelInput, OpenAIModelResponse> result : batch) {
- assertNotNull("Output should not be null",
- result.getOutput().getModelResponse());
- assertFalse("Output should not be empty",
- result.getOutput().getModelResponse().trim().isEmpty());
- }
- }
- return null;
- });
+ PCollection<OpenAIModelInput> inputs =
+ pipeline
+ .apply("CreateInput", Create.of(input))
+ .apply(
+ "MapToInput",
+ MapElements.into(TypeDescriptor.of(OpenAIModelInput.class))
+ .via(OpenAIModelInput::create));
+
+ PCollection<Iterable<PredictionResult<OpenAIModelInput, OpenAIModelResponse>>> results =
+ inputs.apply(
+ "DifferentModelInference",
+ RemoteInference.<OpenAIModelInput, OpenAIModelResponse>invoke()
+ .handler(OpenAIModelHandler.class)
+ .withParameters(
+ OpenAIModelParameters.builder()
+ .apiKey(apiKey)
+ .modelName("gpt-5")
Review Comment:
Good to know Gemini is behind the times, this is ignorable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org