You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2013/01/23 03:44:00 UTC
Review Request: [OOZIE-1185] Retry jms connections on failure
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9061/
-----------------------------------------------------------
Review request for oozie.
Description
-------
Retry jms connections on failure backing off exponentially (1min,2 min, 4,8,16..) up to a max limit
This addresses bug OOZIE-1185.
https://issues.apache.org/jira/browse/OOZIE-1185
Diffs
-----
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java 1437215
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java 1437215
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java 1437215
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java PRE-CREATION
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1437215
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/SchedulerService.java 1437215
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1437215
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/test/MiniHCatServer.java 1437215
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/hcatalog-0.6.0-SNAPSHOT/pom.xml 1437215
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/src/main/assemblies/hcataloglib.xml 1437215
Diff: https://reviews.apache.org/r/9061/diff/
Testing
-------
Thanks,
Rohini Palaniswamy
Re: Review Request: [OOZIE-1185] Retry jms connections on failure
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9061/
-----------------------------------------------------------
(Updated Jan. 25, 2013, 12:03 a.m.)
Review request for oozie.
Changes
-------
Addressed review comments
Description
-------
Retry jms connections on failure backing off exponentially (1min,2 min, 4,8,16..) up to a max limit
This addresses bug OOZIE-1185.
https://issues.apache.org/jira/browse/OOZIE-1185
Diffs (updated)
-----
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java 1438270
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java 1438270
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java 1438270
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java PRE-CREATION
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1438270
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/SchedulerService.java 1438270
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1438270
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/test/MiniHCatServer.java 1438270
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/hcatalog-0.6.0-SNAPSHOT/pom.xml 1438270
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/hcatalog-0.6/pom.xml PRE-CREATION
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/pom.xml 1438270
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1438270
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/src/main/assemblies/hcataloglib.xml 1438270
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/src/main/assemblies/hcataloglibs.xml 1438270
Diff: https://reviews.apache.org/r/9061/diff/
Testing
-------
Thanks,
Rohini Palaniswamy
Re: Review Request: [OOZIE-1185] Retry jms connections on failure
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On Jan. 24, 2013, 11:20 p.m., Virag Kothari wrote:
> > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java, line 27
> > <https://reviews.apache.org/r/9061/diff/2/?file=251720#file251720line27>
> >
> > javadoc here and for other public stuff
Done. Did not do for methods with @Override as it is not required.
> On Jan. 24, 2013, 11:20 p.m., Virag Kothari wrote:
> > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/SchedulerService.java, line 188
> > <https://reviews.apache.org/r/9061/diff/2/?file=251722#file251722line188>
> >
> > Can we reuse the existing methods of Scheduler SErvice
No. Want to schedule only once after a delay. Existing methods do it repeatedly based on a interval
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9061/#review15659
-----------------------------------------------------------
On Jan. 25, 2013, 12:03 a.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9061/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2013, 12:03 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> Retry jms connections on failure backing off exponentially (1min,2 min, 4,8,16..) up to a max limit
>
>
> This addresses bug OOZIE-1185.
> https://issues.apache.org/jira/browse/OOZIE-1185
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java 1438270
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java 1438270
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java 1438270
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1438270
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/SchedulerService.java 1438270
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1438270
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/test/MiniHCatServer.java 1438270
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/hcatalog-0.6.0-SNAPSHOT/pom.xml 1438270
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/hcatalog-0.6/pom.xml PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/pom.xml 1438270
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1438270
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/src/main/assemblies/hcataloglib.xml 1438270
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/src/main/assemblies/hcataloglibs.xml 1438270
>
> Diff: https://reviews.apache.org/r/9061/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request: [OOZIE-1185] Retry jms connections on failure
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9061/#review15659
-----------------------------------------------------------
Ship it!
+1..looks good...couple of comments below
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java
<https://reviews.apache.org/r/9061/#comment33783>
javadoc here and for other public stuff
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java
<https://reviews.apache.org/r/9061/#comment33781>
this method may be called simultaneously for the same jmsconnectString
so we should only schedule retry for a connection if its not already done
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/SchedulerService.java
<https://reviews.apache.org/r/9061/#comment33782>
Can we reuse the existing methods of Scheduler SErvice
- Virag Kothari
On Jan. 24, 2013, 9:58 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9061/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 9:58 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> Retry jms connections on failure backing off exponentially (1min,2 min, 4,8,16..) up to a max limit
>
>
> This addresses bug OOZIE-1185.
> https://issues.apache.org/jira/browse/OOZIE-1185
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java 1438212
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java 1438212
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java 1438212
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1438212
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/SchedulerService.java 1438212
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1438212
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/test/MiniHCatServer.java 1438212
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/hcatalog-0.6.0-SNAPSHOT/pom.xml 1438212
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/hcatalog-0.6/pom.xml PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/pom.xml 1438212
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1438212
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/src/main/assemblies/hcataloglib.xml 1438212
> http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/src/main/assemblies/hcataloglibs.xml 1438212
>
> Diff: https://reviews.apache.org/r/9061/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request: [OOZIE-1185] Retry jms connections on failure
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9061/
-----------------------------------------------------------
(Updated Jan. 24, 2013, 9:58 p.m.)
Review request for oozie.
Changes
-------
Fixed mkdistro failure.
Description
-------
Retry jms connections on failure backing off exponentially (1min,2 min, 4,8,16..) up to a max limit
This addresses bug OOZIE-1185.
https://issues.apache.org/jira/browse/OOZIE-1185
Diffs (updated)
-----
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java 1438212
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java 1438212
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java 1438212
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java PRE-CREATION
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1438212
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/SchedulerService.java 1438212
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1438212
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/test/MiniHCatServer.java 1438212
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/hcatalog-0.6.0-SNAPSHOT/pom.xml 1438212
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/hcatalog-0.6/pom.xml PRE-CREATION
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/pom.xml 1438212
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1438212
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/src/main/assemblies/hcataloglib.xml 1438212
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/src/main/assemblies/hcataloglibs.xml 1438212
Diff: https://reviews.apache.org/r/9061/diff/
Testing
-------
Thanks,
Rohini Palaniswamy