You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lifepuzzlefun (via GitHub)" <gi...@apache.org> on 2023/06/28 14:01:39 UTC

[GitHub] [pulsar] lifepuzzlefun commented on a diff in pull request #20595: [fix][client] Make the whole grabCnx() progress atomic

lifepuzzlefun commented on code in PR #20595:
URL: https://github.com/apache/pulsar/pull/20595#discussion_r1245264041


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -905,9 +909,11 @@ public void connectionOpened(final ClientCnx cnx) {
                     // consumer was subscribed and connected but we got some error, keep trying
                     reconnectLater(e.getCause());

Review Comment:
   hi, i notice the `Connection` impl will have a chance to do reconnect logic when call `connectionOpened` it seems unnecessary now. what reconnection logic do we expect ? always handle by ConnectionHandler or by `Connection` impl themself ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org