[GitHub] [airflow] potiuk commented on a change in pull request #6321: [AIRFLOW-5649] Skips some tests for non relevant changes

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #6321: [AIRFLOW-5649] Skips some tests for non relevant changes
URL: https://github.com/apache/airflow/pull/6321#discussion_r335939221
 
 

 ##########
 File path: scripts/ci/_utils.sh
 ##########
 @@ -910,15 +927,39 @@ function build_image_on_ci() {
     # Cleanup docker installation. It should be empty in CI but let's not risk
     docker system prune --all --force
     rm -rf "${BUILD_CACHE_DIR}"
+    mkdir -pv "${BUILD_CACHE_DIR}"
 
-    if [[ ${TRAVIS_JOB_NAME:=""} == "Tests"* ]]; then
-        rebuild_ci_image_if_needed
+    CHANGED_FILE_NAMES=$(git diff --name-only "${TRAVIS_BRANCH:="HEAD"}...HEAD")
+    echo
+    echo "Changed file names in this commit"
+    echo "$CHANGED_FILE_NAMES"
+    echo
+
+    if [[ ${TRAVIS_JOB_NAME:=""} == "Tests"*"kubernetes"* ]]; then
+        match_files_regexp 'airflow/kubernetes/.*\.py' 'tests/kubernetes/.*\.py'
 
 Review comment:
   I also changed it so that all tests are always run in CRON job run daily. I do expect some false positives to slip through.
   
   For now I think it is best to include airflow/www/*.py in kubernetes and airflow/www/static/*.js  in general (not only .py) to both regexps. That should handle big class of potential false positives. 
   
   I think it's a good safety net eventually. 
   
   Possibly if we find there are other dependencies, we can add them after we see they fail in the CRON job.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services