You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/25 13:40:43 UTC
[GitHub] [incubator-kyuubi] turboFei opened a new pull request #1291: Make kinit command could run for osx environment
turboFei opened a new pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1291: Make kerberos enabled kyuubi server unit test runnable for osx environment
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r735654467
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
##########
@@ -45,7 +45,8 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing")
UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
- val commands = Seq("kinit", "-kt", keytab.get, principal.get)
+ val krb5Conf = System.getProperty("java.security.krb5.conf")
+ val commands = Seq(s"env KRB5_CONFIG=$krb5Conf", "kinit", "-kt", keytab.get, principal.get)
Review comment:
Is it possible that, for the commands executed in processBuilder, its default KRB5_CONFIG is not same with the value of `java.security.krb5.conf`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1291: Make kinit command runnable run for osx environment with KDC testing
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r735616847
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/KerberizedTestHelper.scala
##########
@@ -95,6 +95,8 @@ trait KerberizedTestHelper extends KyuubiFunSuite {
if (s.contains("libdefaults")) {
rewritten = true
s + addedConfig
+ } else if (s.contains(hostName)) {
+ s + "\n" + s.replace(hostName, s"tcp/$hostName")
Review comment:
Let's add a stackoverflow link to explain the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1291: [TEST] Transfer KRB5_CONF to kinit and fix kerberos UT on macOS
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#issuecomment-951155603
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1291: Make kerberos enabled kyuubi server unit test runnable for osx environment
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r735640869
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
##########
@@ -45,7 +45,8 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing")
UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
- val commands = Seq("kinit", "-kt", keytab.get, principal.get)
+ val krb5Conf = System.getProperty("java.security.krb5.conf")
Review comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1291: Transfer KRB5_CONF of KyuubiServer to kinit process and make kerberos enabled kyuubi server unit test runnable for osx env
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#issuecomment-950962560
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1291](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f006054) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/ccb8117cff16ba26e3e219274e9c3b230482f637?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ccb8117) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1291 +/- ##
=========================================
Coverage 78.27% 78.27%
Complexity 110 110
=========================================
Files 177 177
Lines 7103 7108 +5
Branches 874 874
=========================================
+ Hits 5560 5564 +4
- Misses 1063 1064 +1
Partials 480 480
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/kyuubi/server/KinitAuxiliaryService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS2luaXRBdXhpbGlhcnlTZXJ2aWNlLnNjYWxh) | `66.66% <100.00%> (+1.96%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ccb8117...f006054](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1291: Make kinit command runnable run for osx environment with KDC testing
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r735621498
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/KerberizedTestHelper.scala
##########
@@ -95,6 +95,8 @@ trait KerberizedTestHelper extends KyuubiFunSuite {
if (s.contains("libdefaults")) {
rewritten = true
s + addedConfig
+ } else if (s.contains(hostName)) {
+ s + "\n" + s.replace(hostName, s"tcp/$hostName")
Review comment:
add into pr desc
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/KerberizedTestHelper.scala
##########
@@ -95,6 +95,8 @@ trait KerberizedTestHelper extends KyuubiFunSuite {
if (s.contains("libdefaults")) {
rewritten = true
s + addedConfig
+ } else if (s.contains(hostName)) {
+ s + "\n" + s.replace(hostName, s"tcp/$hostName")
Review comment:
added into pr desc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1291: Make kerberos enabled kyuubi server unit test runnable for osx environment
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r735634369
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/KerberizedTestHelper.scala
##########
@@ -95,6 +95,8 @@ trait KerberizedTestHelper extends KyuubiFunSuite {
if (s.contains("libdefaults")) {
rewritten = true
s + addedConfig
+ } else if (s.contains(hostName)) {
+ s + "\n" + s.replace(hostName, s"tcp/$hostName")
Review comment:
add alternative kdc for OSX environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1291: [TEST] Transfer KRB5_CONF to kinit and fix kerberos UT on macOS
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1291: Make kerberos enabled kyuubi server unit test runnable for osx environment
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r735633914
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
##########
@@ -45,7 +45,8 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing")
UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
- val commands = Seq("kinit", "-kt", keytab.get, principal.get)
+ val krb5Conf = System.getProperty("java.security.krb5.conf")
+ val commands = Seq(s"env KRB5_CONFIG=$krb5Conf", "kinit", "-kt", keytab.get, principal.get)
Review comment:
I do not know why, but I have to add `env KRB5_CONFIG=$krb5Conf` here to make it run on macbook
@yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1291: [TEST] Transfer KRB5_CONF to kinit and fix kerberos UT on macOS
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r736086506
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
##########
@@ -45,8 +45,12 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing")
UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
+ val krb5Conf = Option(System.getProperty("java.security.krb5.conf"))
+ .orElse(Option(System.getenv("KRB5_CONFIG")))
Review comment:
Shall we add KRB5_CONFIG to kyuubi-env.sh.template?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1291: Make kerberos enabled kyuubi server unit test runnable for osx environment
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r735633914
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
##########
@@ -45,7 +45,8 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing")
UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
- val commands = Seq("kinit", "-kt", keytab.get, principal.get)
+ val krb5Conf = System.getProperty("java.security.krb5.conf")
+ val commands = Seq(s"env KRB5_CONFIG=$krb5Conf", "kinit", "-kt", keytab.get, principal.get)
Review comment:
I do not know why, but I have to add `env KRB5_CONFIG=$krb5Conf` here to make it runnable on macbook
@yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1291: Transfer KRB5_CONF of KyuubiServer to kint process and make kerberos enabled kyuubi server unit test runnable for osx env
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r735654467
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
##########
@@ -45,7 +45,8 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing")
UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
- val commands = Seq("kinit", "-kt", keytab.get, principal.get)
+ val krb5Conf = System.getProperty("java.security.krb5.conf")
+ val commands = Seq(s"env KRB5_CONFIG=$krb5Conf", "kinit", "-kt", keytab.get, principal.get)
Review comment:
for the commands executed in processBuilder, its default KRB5_CONFIG is not same with the value of `java.security.krb5.conf`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1291: Transfer KRB5_CONF of KyuubiServer to kint process and make kerberos enabled kyuubi server unit test runnable for osx env
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#issuecomment-950962560
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1291](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9fda6b3) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/ccb8117cff16ba26e3e219274e9c3b230482f637?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ccb8117) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 9fda6b3 differs from pull request most recent head f006054. Consider uploading reports for the commit f006054 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1291 +/- ##
=========================================
Coverage 78.27% 78.28%
Complexity 110 110
=========================================
Files 177 177
Lines 7103 7105 +2
Branches 874 874
=========================================
+ Hits 5560 5562 +2
- Misses 1063 1064 +1
+ Partials 480 479 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/kyuubi/server/KinitAuxiliaryService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS2luaXRBdXhpbGlhcnlTZXJ2aWNlLnNjYWxh) | `66.66% <100.00%> (+1.96%)` | :arrow_up: |
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `53.48% <0.00%> (-2.33%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `90.90% <0.00%> (+1.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ccb8117...f006054](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1291: Make kerberos enabled kyuubi server unit test runnable for osx environment
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r735654467
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
##########
@@ -45,7 +45,8 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing")
UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
- val commands = Seq("kinit", "-kt", keytab.get, principal.get)
+ val krb5Conf = System.getProperty("java.security.krb5.conf")
+ val commands = Seq(s"env KRB5_CONFIG=$krb5Conf", "kinit", "-kt", keytab.get, principal.get)
Review comment:
Is it possible that, for the command in processBuilder, its default KRB5_CONFIG is not same with the value of `java.security.krb5.conf`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1291: [TEST] Transfer KRB5_CONF to kinit and fix kerberos UT on macOS
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r736086232
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
##########
@@ -45,8 +45,12 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing")
UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
+ val krb5Conf = Option(System.getProperty("java.security.krb5.conf"))
Review comment:
Shall we get it from KyuubiConf？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1291: Make kerberos enabled kyuubi server unit test runnable for osx environment
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#issuecomment-950962560
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1291](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffbbfa7) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/ccb8117cff16ba26e3e219274e9c3b230482f637?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ccb8117) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head ffbbfa7 differs from pull request most recent head 0aaf376. Consider uploading reports for the commit 0aaf376 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1291 +/- ##
=========================================
Coverage 78.27% 78.27%
Complexity 110 110
=========================================
Files 177 177
Lines 7103 7104 +1
Branches 874 874
=========================================
+ Hits 5560 5561 +1
Misses 1063 1063
Partials 480 480
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/kyuubi/server/KinitAuxiliaryService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS2luaXRBdXhpbGlhcnlTZXJ2aWNlLnNjYWxh) | `65.71% <100.00%> (+1.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ccb8117...0aaf376](https://codecov.io/gh/apache/incubator-kyuubi/pull/1291?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] zjffdu commented on a change in pull request #1291: Make kerberos enabled kyuubi server unit test runnable for osx environment
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r735635801
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
##########
@@ -45,7 +45,8 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing")
UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
- val commands = Seq("kinit", "-kt", keytab.get, principal.get)
+ val krb5Conf = System.getProperty("java.security.krb5.conf")
Review comment:
It is possible to be null in case user doesn't set it. IIRC, the default location is `/etc/krb5.conf`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1291: Transfer KRB5_CONF of KyuubiServer to kint process and make kerberos enabled kyuubi server unit test runnable for osx env
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r735654467
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
##########
@@ -45,7 +45,8 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing")
UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
- val commands = Seq("kinit", "-kt", keytab.get, principal.get)
+ val krb5Conf = System.getProperty("java.security.krb5.conf")
+ val commands = Seq(s"env KRB5_CONFIG=$krb5Conf", "kinit", "-kt", keytab.get, principal.get)
Review comment:
for the commands executed in processBuilder, its default KRB5_CONFIG is not same with the value of `java.security.krb5.conf` of KyuubiServer JVM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1291: Transfer KRB5_CONF of KyuubiServer to kint process and make kerberos enabled kyuubi server unit test runnable for osx env
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-kyuubi/pull/1291#discussion_r735633914
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
##########
@@ -45,7 +45,8 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
require(keytab.nonEmpty && principal.nonEmpty, "principal or keytab is missing")
UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
- val commands = Seq("kinit", "-kt", keytab.get, principal.get)
+ val krb5Conf = System.getProperty("java.security.krb5.conf")
+ val commands = Seq(s"env KRB5_CONFIG=$krb5Conf", "kinit", "-kt", keytab.get, principal.get)
Review comment:
I do not know why, but I have to add `env KRB5_CONFIG=$krb5Conf` here to make it runnable on macbook
@yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org