You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/12/05 01:10:34 UTC

[GitHub] betodealmeida opened a new pull request #4003: Call props.onChange only when closing filter

betodealmeida opened a new pull request #4003: Call props.onChange only when closing filter
URL: https://github.com/apache/incubator-superset/pull/4003
 
 
   The `DateFilterControl` component calls `props.onChange` on its `onChange`, propagating instantly the values selected before "Ok" is clicked. This PR moves the call to `props.OnChange` to the `close` function, so that the new values are propagated only when "Ok" is clicked.
   
   Screencast:
   
   ![out](https://user-images.githubusercontent.com/1534870/33584523-aae85f72-d914-11e7-88c9-81e24d5d0e7d.gif)
   
   Unit test and lint ran fine:
   
       $ cd superset/assets/javascripts
       $ npm i
       $ npm run test
       ...
       409 passing (3s)
       $ npm run lint
       <no messages>
   
   This PR fixes #3868.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services