You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/20 12:21:18 UTC
[GitHub] [flink] godfreyhe opened a new pull request #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
godfreyhe opened a new pull request #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158
## What is the purpose of the change
*currently AggregateProjectPullUpConstantsRule is in cost-based phase (logical phase), while RelMdPredicates does not work when meeting RelSubset. So we can add AggregateProjectPullUpConstantsRule into hep planner to fix the bug.*
## Brief change log
- *add AggregateProjectPullUpConstantsRule into default_write phase*
## Verifying this change
This change added tests and can be verified as follows:
- *Added testGroupByConstantKey method in AggregateTest to validate constant group key in queres*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-604779361
@JingsongLi thanks for the review, I have added a IT case to test upsert sink with primary key
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
Hash:8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149811021 TriggerType:PUSH TriggerID:8d5d2238515b1d63bf1591e1b1bbef8611af5c99
Hash:8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366 TriggerType:PUSH TriggerID:8d5d2238515b1d63bf1591e1b1bbef8611af5c99
Hash:8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c
-->
## CI report:
* 8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149811021) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366)
* 8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi merged pull request #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149811021",
"triggerID" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"triggerType" : "PUSH"
}, {
"hash" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366",
"triggerID" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"triggerType" : "PUSH"
}, {
"hash" : "8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149936916",
"triggerID" : "8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c",
"triggerType" : "PUSH"
}, {
"hash" : "7a4635a9699b7b524265c41ccb0ddedf5dd30e0e",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/155728830",
"triggerID" : "7a4635a9699b7b524265c41ccb0ddedf5dd30e0e",
"triggerType" : "PUSH"
}, {
"hash" : "7a4635a9699b7b524265c41ccb0ddedf5dd30e0e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6710",
"triggerID" : "7a4635a9699b7b524265c41ccb0ddedf5dd30e0e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a4635a9699b7b524265c41ccb0ddedf5dd30e0e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155728830) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6710)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149811021",
"triggerID" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"triggerType" : "PUSH"
}, {
"hash" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366",
"triggerID" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"triggerType" : "PUSH"
}, {
"hash" : "8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149936916",
"triggerID" : "8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c",
"triggerType" : "PUSH"
}, {
"hash" : "7a4635a9699b7b524265c41ccb0ddedf5dd30e0e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7a4635a9699b7b524265c41ccb0ddedf5dd30e0e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149936916)
* 7a4635a9699b7b524265c41ccb0ddedf5dd30e0e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149811021",
"triggerID" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"triggerType" : "PUSH"
}, {
"hash" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366",
"triggerID" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"triggerType" : "PUSH"
}, {
"hash" : "8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149936916",
"triggerID" : "8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149811021) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366)
* 8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149936916)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
Hash:8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149811021 TriggerType:PUSH TriggerID:8d5d2238515b1d63bf1591e1b1bbef8611af5c99
Hash:8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366 TriggerType:PUSH TriggerID:8d5d2238515b1d63bf1591e1b1bbef8611af5c99
-->
## CI report:
* 8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149811021) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-605788193
Merged, thanks for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149811021",
"triggerID" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"triggerType" : "PUSH"
}, {
"hash" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366",
"triggerID" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"triggerType" : "PUSH"
}, {
"hash" : "8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149936916",
"triggerID" : "8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149936916)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-605786557
Can you create a PR for release-1.10?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149811021",
"triggerID" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"triggerType" : "PUSH"
}, {
"hash" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366",
"triggerID" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"triggerType" : "PUSH"
}, {
"hash" : "8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149936916",
"triggerID" : "8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c",
"triggerType" : "PUSH"
}, {
"hash" : "7a4635a9699b7b524265c41ccb0ddedf5dd30e0e",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/155728830",
"triggerID" : "7a4635a9699b7b524265c41ccb0ddedf5dd30e0e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149936916)
* 7a4635a9699b7b524265c41ccb0ddedf5dd30e0e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155728830)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-588995561
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8d5d2238515b1d63bf1591e1b1bbef8611af5c99 (Thu Feb 20 12:24:55 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149811021",
"triggerID" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"triggerType" : "PUSH"
}, {
"hash" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366",
"triggerID" : "8d5d2238515b1d63bf1591e1b1bbef8611af5c99",
"triggerType" : "PUSH"
}, {
"hash" : "8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149936916",
"triggerID" : "8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c",
"triggerType" : "PUSH"
}, {
"hash" : "7a4635a9699b7b524265c41ccb0ddedf5dd30e0e",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/155728830",
"triggerID" : "7a4635a9699b7b524265c41ccb0ddedf5dd30e0e",
"triggerType" : "PUSH"
}, {
"hash" : "7a4635a9699b7b524265c41ccb0ddedf5dd30e0e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6710",
"triggerID" : "7a4635a9699b7b524265c41ccb0ddedf5dd30e0e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a4635a9699b7b524265c41ccb0ddedf5dd30e0e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/155728830) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6710)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
Hash:8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149811021 TriggerType:PUSH TriggerID:8d5d2238515b1d63bf1591e1b1bbef8611af5c99
Hash:8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366 TriggerType:PUSH TriggerID:8d5d2238515b1d63bf1591e1b1bbef8611af5c99
Hash:8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149936916 TriggerType:PUSH TriggerID:8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c
-->
## CI report:
* 8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149811021) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366)
* 8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149936916)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
Hash:8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149811021 TriggerType:PUSH TriggerID:8d5d2238515b1d63bf1591e1b1bbef8611af5c99
-->
## CI report:
* 8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149811021)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
Hash:8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8d5d2238515b1d63bf1591e1b1bbef8611af5c99
-->
## CI report:
* 8d5d2238515b1d63bf1591e1b1bbef8611af5c99 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
Hash:8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149811021 TriggerType:PUSH TriggerID:8d5d2238515b1d63bf1591e1b1bbef8611af5c99
Hash:8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366 TriggerType:PUSH TriggerID:8d5d2238515b1d63bf1591e1b1bbef8611af5c99
Hash:8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149936916 TriggerType:PUSH TriggerID:8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c
-->
## CI report:
* 8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149811021) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366)
* 8f3212ca7ae2fff228a1ca0f4edf6423f9f7b40c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149936916)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-589009467
<!--
Meta data
Hash:8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149811021 TriggerType:PUSH TriggerID:8d5d2238515b1d63bf1591e1b1bbef8611af5c99
Hash:8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366 TriggerType:PUSH TriggerID:8d5d2238515b1d63bf1591e1b1bbef8611af5c99
-->
## CI report:
* 8d5d2238515b1d63bf1591e1b1bbef8611af5c99 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149811021) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5366)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #11158: [FLINK-16070]
[table-planner-blink] blink stream planner supports remove constant keys
from an aggregate
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #11158: [FLINK-16070] [table-planner-blink] blink stream planner supports remove constant keys from an aggregate
URL: https://github.com/apache/flink/pull/11158#issuecomment-605787304
> +1, should we add this rule to batch too?
Batch has already contained this rule
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services