You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/17 14:56:49 UTC
[GitHub] [geode] albertogpz commented on pull request #5257: GEODE-8251: make sure Configuration can be deserialized post 1.12.
albertogpz commented on pull request #5257:
URL: https://github.com/apache/geode/pull/5257#issuecomment-645426599
> > What's the point for these changes?
> > I have ran the test case without them and it passes.
> > Also, I have searched in the Geode code for the use of this file and have only found it in `ObjectInputStreamFilterWrapper.java`. From what I see there, only the first part of every line, the class name, is used.
> > What am I missing?
>
> the previous version of Deployment has variable name "jarFileName" instead of "fileName", when we are deserializing a previous version bytes, if the variable name doesn't match, it won't take the value. We should have a test to verify that, but I saw the behavior in the debugger.
I understand that. What I do not get are the changes in the
> > What's the point for these changes?
> > I have ran the test case without them and it passes.
> > Also, I have searched in the Geode code for the use of this file and have only found it in `ObjectInputStreamFilterWrapper.java`. From what I see there, only the first part of every line, the class name, is used.
> > What am I missing?
>
> the previous version of Deployment has variable name "jarFileName" instead of "fileName", when we are deserializing a previous version bytes, if the variable name doesn't match, it won't take the value. We should have a test to verify that, but I saw the behavior in the debugger.
I understand the change in the members of the class. What I do not get is why it needs to be reflected in sanctioned-geode-management-serializables.txt.
Who is accessing that file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org