You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2016/08/25 15:43:35 UTC

[GitHub] brooklyn-server pull request #308: Invoke on sensor and ssh to multiple

GitHub user ahgittin opened a pull request:

    https://github.com/apache/brooklyn-server/pull/308

    Invoke on sensor and ssh to multiple

    These fixes make https://github.com/brooklyncentral/brooklyn-dns work neatly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/brooklyn-server invoke-on-sensor-and-ssh-to-multiple

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #308
    
----
commit 8ff627cbbfb104c4dc60341a95e256909439dd57
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2016-08-25T15:07:57Z

    subscriptions should base on sensor name, not the object

commit 2ab4e5c10a6df18353cee5e3c4b51a6ddec76c0f
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2016-08-25T15:16:23Z

    add InvokeEffectorOnSensorChange and let SSH run over members
    
    helps w DNS, likely many others

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #308: Invoke on sensor and ssh to multiple

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/308#discussion_r76400099
  
    --- Diff: core/src/main/java/org/apache/brooklyn/policy/InvokeEffectorOnSensorChange.java ---
    @@ -0,0 +1,71 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.policy;
    +
    +import java.util.Map;
    +
    +import org.apache.brooklyn.api.effector.Effector;
    +import org.apache.brooklyn.api.entity.EntityLocal;
    +import org.apache.brooklyn.api.sensor.Sensor;
    +import org.apache.brooklyn.api.sensor.SensorEvent;
    +import org.apache.brooklyn.api.sensor.SensorEventListener;
    +import org.apache.brooklyn.config.ConfigKey;
    +import org.apache.brooklyn.core.config.ConfigKeys;
    +import org.apache.brooklyn.core.policy.AbstractPolicy;
    +import org.apache.brooklyn.core.sensor.Sensors;
    +import org.apache.brooklyn.util.collections.MutableMap;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.google.common.base.Preconditions;
    +
    +/**
    + * Invokes the given effector when the policy changes.
    + * 
    + * TODO
    + * * support parameters
    + * * support conditions
    + * * allow to be triggered by sensors on members
    + */
    +public class InvokeEffectorOnSensorChange extends AbstractPolicy implements SensorEventListener<Object> {
    +    
    +    private static final Logger LOG = LoggerFactory.getLogger(InvokeEffectorOnSensorChange.class);
    +
    +    public static final ConfigKey<Object> SENSOR = ConfigKeys.newConfigKey(Object.class, 
    --- End diff --
    
    happy for that to be added, along with a debounce, but then we'll also want a way to pass the sensor and originator as parameters to the effector ... so i've started simple
    
    feel free to add when needed
    
    i like having both `sensor` and `sensorsToTrack` and they are additive



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---