[jira] [Commented] (STANBOL-1468) Inconsistent method name "toLRU"

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STANBOL-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684458#comment-16684458 ] 

ASF GitHub Bot commented on STANBOL-1468:
-----------------------------------------

Github user BruceKuiLiu closed the pull request at:

    https://github.com/apache/stanbol/pull/7


> Inconsistent method name "toLRU"
> --------------------------------
>
>                 Key: STANBOL-1468
>                 URL: https://issues.apache.org/jira/browse/STANBOL-1468
>             Project: Stanbol
>          Issue Type: Improvement
>            Reporter: KuiLIU
>            Priority: Major
>         Attachments: rename-method.patch
>
>
> The following method "toLRU" is adding the data of the paraement 'r' to the variable "lru", but it is named "toLRU". "toLRU" seems to mean that converting one object to another one, so that "toLRU" may be confusing. "addToLRU" should be better.
> {code:java}
>      private void toLRU(Representation r){
>          lru.put(r.getId(), r);
>      }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)