[GitHub] [trafficserver] shinrich edited a comment on pull request #7134: Do not lose original inactivity timeout on disable

[GitBox <gi...@apache.org>]

shinrich edited a comment on pull request #7134:
URL: https://github.com/apache/trafficserver/pull/7134#issuecomment-684925701


   In the tunnel case, it seems that disabling both write and read on the netvc is a transient operation.  With the current code, we need to explicitly reset the inactivity timeout when the netvc is reenabled.  I'll look around about how to do that at the HttpSM level.
   
   I assume that net_activity() won't trigger until the netvc has been reenabled for read or write.  If that is the case, then having the net_activity reset the previously set inactivity timeout seems reasonable.  
   
   I just looked through the code, and indeed it appears that net_activity will only be called if the netvc is in fact enabled, so having net_activity() reset the previously set inactivity timeout seems like a good thing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org