[DISCUSS] Java 11

[Stephen Mallette <sp...@gmail.com>]

I've been working on getting TinkerPop building on Java 11.

https://issues.apache.org/jira/browse/TINKERPOP-2076

I started the work on the tp33 branch and have hit the first problem I
where I had some doubts about how to proceed. gremlin-groovy wont' build
with the current version of gmaven-plus which needs groovy 2.5.3 minimum.
we had long ago decided against a version bump for groovy on tp33 and
decided to let it live on 2.4.x. So, if we want tp33 to build on Java 11 we
would need to change that thinking which would mean backporting several
commits from master to tp33 around groovy upgrades. Specifically we would
need:

https://github.com/apache/tinkerpop/commit/80242be387e6d3b4daa0a7b045d7a4f463123321
(2.5.2)
https://github.com/apache/tinkerpop/commit/759d1a724eef3f76b48508ba8c49dcb992eff28f
(2.5.3)

From there it's an easy jump to what master is currently on at 2.5.6. As I
finish writing this email I'm not sure I really have a doubt anymore....I
think I need to move ahead with this change because without it we'll have
to switch Java versions every time we switch branches and that's not nice.
Based on that, I guess I'll just move forward upgrading Groovy to 2.5.6 on
tp33. Hope that makes sense to everyone.

Re: [DISCUSS] Java 11

[Stephen Mallette <sp...@gmail.com>]

I think I'm blockaded on Java 11 at this point. I've explained the
situation in the last comment on the JIRA here:

https://issues.apache.org/jira/browse/TINKERPOP-2076?focusedCommentId=16787167&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16787167

but the short story is that Spark isn't working right on Java 11 partly
because Hadoop isn't working right on Java 11. The problem is compounded by
the fact that even when Spark is released Java 11 support will likely only
land on Spark 3.0 and given that TP 3.3.x and 3.4.x are bound to 2.x and
likely staying there we probably wouldn't try to get Java 11 going until TP
3.5.0. And that of course stinks because then we have different Java
version requirements between branches - booooo.

I believe that I should rebase my branch to master at this time and just
keep it up to date because I did good work on that and solved a lot of
upgrade problems. If anyone has a different sense of what's going on with
Spark and Java 11, please let us  know. Also, if you think we should go
with a different plan for Java 11 support other than what I've laid out,
then let's please discuss.



On Tue, Mar 5, 2019 at 1:44 PM Stephen Mallette <sp...@gmail.com>
wrote:

> I've been working on getting TinkerPop building on Java 11.
>
> https://issues.apache.org/jira/browse/TINKERPOP-2076
>
> I started the work on the tp33 branch and have hit the first problem I
> where I had some doubts about how to proceed. gremlin-groovy wont' build
> with the current version of gmaven-plus which needs groovy 2.5.3 minimum.
> we had long ago decided against a version bump for groovy on tp33 and
> decided to let it live on 2.4.x. So, if we want tp33 to build on Java 11 we
> would need to change that thinking which would mean backporting several
> commits from master to tp33 around groovy upgrades. Specifically we would
> need:
>
>
> https://github.com/apache/tinkerpop/commit/80242be387e6d3b4daa0a7b045d7a4f463123321
> (2.5.2)
>
> https://github.com/apache/tinkerpop/commit/759d1a724eef3f76b48508ba8c49dcb992eff28f
> (2.5.3)
>
> From there it's an easy jump to what master is currently on at 2.5.6. As I
> finish writing this email I'm not sure I really have a doubt anymore....I
> think I need to move ahead with this change because without it we'll have
> to switch Java versions every time we switch branches and that's not nice.
> Based on that, I guess I'll just move forward upgrading Groovy to 2.5.6 on
> tp33. Hope that makes sense to everyone.
>
>
>