You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/05 11:06:33 UTC
[GitHub] [arrow] mqy opened a new pull request #9101: ARROW-11131: [Rust] Improve performance of bool_equal
mqy opened a new pull request #9101:
URL: https://github.com/apache/arrow/pull/9101
This PR follows https://github.com/apache/arrow/pull/8541,
1. Implement the logic when both `lhs` and `rhs` have zero null count.
2. May fixed a possible condition testing bug in `(0..len).all(|i| {...}` .
NOTE: there are other similar cases where `test_struct()` failed when changed to these way.
3. Add benchmarks `equal_bool_512` and `equal_bool_nulls_512`.
Benchmark comparing to arrow master:
`equal_bool_512 time: [52.946 ns 53.075 ns 53.188 ns]
change: [-96.295% -96.285% -96.277%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) low severe
2 (2.00%) high mild
2 (2.00%) high severe
equal_bool_nulls_512 time: [2.3502 us 2.3696 us 2.3893 us]
change: [-62.285% -62.019% -61.714%] (p = 0.00 < 0.05)
Performance has improved.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9101: ARROW-11131: [Rust] Improve performance of bool_equal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9101:
URL: https://github.com/apache/arrow/pull/9101#issuecomment-754570371
https://issues.apache.org/jira/browse/ARROW-11131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9101: ARROW-11131: [Rust] Improve performance of bool_equal
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9101:
URL: https://github.com/apache/arrow/pull/9101#issuecomment-754580244
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9101?src=pr&el=h1) Report
> Merging [#9101](https://codecov.io/gh/apache/arrow/pull/9101?src=pr&el=desc) (4dd6bfb) into [master](https://codecov.io/gh/apache/arrow/commit/86cf246d161512923253baa8fe62e00de88db73a?el=desc) (86cf246) will **increase** coverage by `0.05%`.
> The diff coverage is `67.24%`.
[](https://codecov.io/gh/apache/arrow/pull/9101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9101 +/- ##
==========================================
+ Coverage 82.60% 82.66% +0.05%
==========================================
Files 204 204
Lines 50175 50327 +152
==========================================
+ Hits 41447 41602 +155
+ Misses 8728 8725 -3
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/equal/boolean.rs](https://codecov.io/gh/apache/arrow/pull/9101/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvYm9vbGVhbi5ycw==) | `69.84% <67.24%> (-30.16%)` | :arrow_down: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9101/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `88.88% <0.00%> (-1.06%)` | :arrow_down: |
| [rust/parquet/src/schema/types.rs](https://codecov.io/gh/apache/arrow/pull/9101/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9zY2hlbWEvdHlwZXMucnM=) | `89.52% <0.00%> (-0.42%)` | :arrow_down: |
| [rust/parquet/src/arrow/array\_reader.rs](https://codecov.io/gh/apache/arrow/pull/9101/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9hcnJheV9yZWFkZXIucnM=) | `75.44% <0.00%> (+0.09%)` | :arrow_up: |
| [rust/parquet/src/arrow/arrow\_reader.rs](https://codecov.io/gh/apache/arrow/pull/9101/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9hcnJvd19yZWFkZXIucnM=) | `91.57% <0.00%> (+0.18%)` | :arrow_up: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9101/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.98% <0.00%> (+0.43%)` | :arrow_up: |
| [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9101/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.52% <0.00%> (+0.58%)` | :arrow_up: |
| [rust/arrow/src/datatypes.rs](https://codecov.io/gh/apache/arrow/pull/9101/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZGF0YXR5cGVzLnJz) | `77.66% <0.00%> (+2.63%)` | :arrow_up: |
| [rust/arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow/pull/9101/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZmZpLnJz) | `75.67% <0.00%> (+3.45%)` | :arrow_up: |
| [rust/arrow/src/record\_batch.rs](https://codecov.io/gh/apache/arrow/pull/9101/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvcmVjb3JkX2JhdGNoLnJz) | `83.96% <0.00%> (+10.13%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9101?src=pr&el=footer). Last update [f49f293...4dd6bfb](https://codecov.io/gh/apache/arrow/pull/9101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy closed pull request #9101: ARROW-11131: [Rust] Improve performance of bool_equal
Posted by GitBox <gi...@apache.org>.
mqy closed pull request #9101:
URL: https://github.com/apache/arrow/pull/9101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org