[jira] [Comment Edited] (ARTEMIS-3141) limit the amount of data returned from jmx/queue control listMessages

["Gary Tully (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298699#comment-17298699 ] 

Gary Tully edited comment on ARTEMIS-3141 at 3/10/21, 11:24 AM:
----------------------------------------------------------------

From the doc, there is: 
management-browse-page-size is the number of messages a management resource can browse. This is relevant for the "browse" management method exposed on the queue control. Default is 200.

The 'page' reference in there seems strange, but maybe in the context of a browse or list it can be the size of a page in the UI, an implicit list limit. 

From the code, it looks like the browse limit is looking in the wrong place for config (using queue name rather than address name), so will always have the default... that is one problem.

however it does have a particular meaning, it limits the number of messages browsed, independent of the filter matching. It will limit the number of messages that are iterated over on the broker.

management-messages-max could still be in play to further limit the number of messages that are returned.



was (Author: gtully):
From the doc, there is: 
management-browse-page-size is the number of messages a management resource can browse. This is relevant for the "browse" management method exposed on the queue control. Default is 200.

The 'page' reference in there seems strange, but maybe in the context of a browse or list it can be the size of a page in the UI, an implicit list limit. 
something like 'management-messages-fetch-limit' would cover both browse and list. Naming configuration is difficult, renaming is even harder!

> limit the amount of data returned from jmx/queue control listMessages
> ---------------------------------------------------------------------
>
>                 Key: ARTEMIS-3141
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3141
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: JMX
>    Affects Versions: 2.17.0
>            Reporter: Gary Tully
>            Priority: Major
>
> The list methods of queue control that are exposed via jmx seem to be unbounded.
>   1) they list all messages
>   2) they display the full body
> To protect both the broker and the browser/UI/client it would make sense to limit both the number of messages and the size of the data that is returned.
> Imaging 500k messages pending messages with a body of 10k... and 400k are paged to disk. It would be crazy to try and list those.
> I imagine a:
>  management-list-messages-max default 256
>  management-list-messages-body-max default 256 or some such.
> I need to do some more tests to verify the extent a broker will do to support the current api. I note that the browse functionality can be paged and with out a page defaults to 200 messages. That is sensible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)